Synchronise presentations for settings and account modals #5248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IOS-334 Custom animations do not respect "Reduce Motion" accessibility setting
We should be checking for the isReduceMotionEnabled setting when doing custom animations |
buggmagnet
approved these changes
Oct 9, 2023
There was a problem hiding this comment.
Easier than I thought, nice !
Reviewable status: 0 of 1 files reviewed, all discussions resolved
rablador
force-pushed
the
custom-animations-do-not-respect-reduce-motion-accessibility-ios-334
branch
2 times, most recently
from
c132dc6 to
9c38f0f
Compare
buggmagnet
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
buggmagnet
force-pushed
the
custom-animations-do-not-respect-reduce-motion-accessibility-ios-334
branch
from
9c38f0f to
423ec44
Compare
buggmagnet
deleted the
custom-animations-do-not-respect-reduce-motion-accessibility-ios-334
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should synchronise presentations for the settings and account modals. Using the style of settings modal also ensures conformance to the "Reduce Motion" accessibility setting.
This change is