-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect changes to interfaces in the dynamic store #5254
Conversation
ed95be6
to
4d83f78
Compare
DES-396 SCDynamicStoreBuilder panics during shutdown DES-398 App gets stuck in offline state
My best guess is that we must react to dynamic store key changes. |
4d83f78
to
1f12dfe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 7 files at r1, 4 of 6 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
talpid-core/src/offline/macos.rs
line 112 at r3 (raw file):
route_event = route_listener.next() => { let Some(event) = route_event else { break;
Should it break
or continue
in this case? Feels like this could be coalesced with let Some(state) = weak_state.ugprade()...
here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved
talpid-core/src/offline/macos.rs
line 112 at r3 (raw file):
Previously, pinkisemils (Emīls Piņķis) wrote…
Should it
break
orcontinue
in this case? Feels like this could be coalesced withlet Some(state) = weak_state.ugprade()...
here.
Definitely break -- this should only return none when the route manager is down.
00fa03a
to
65b00ba
Compare
This PR makes a few changes:
Fix DES-398
Fix DES-396
This change is