Add device name and time left to main view

[Rawa]

Adds the device name and time left to the main view.

---

This change is 

[linear]

DROID-90 Add device name and time left to main view

Some users have sent emails to support saying that they do not understand the device name concept, see discussion in Slack here. It was decided that having the device name be shown in the main view and adding info buttons with dialogs explaining the device concept could mitigate this. To also give users some more information about their new device an in-app banner message appears upon login that users need to close manually.

Note: The Confluence and Zeplin links references other work as well, for instance the Project Better inform users about time left on account

---

Confluence: https://mullvad.atlassian.net/l/cp/1tRhWft7

Zeplin: https://zpl.io/noZAypY

[Pururun]

Reviewed 57 of 57 files at r1, 1 of 5 files at r2, all commit messages.
Reviewable status: 57 of 61 files reviewed, 2 unresolved discussions (waiting on @Rawa)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/component/TopBar.kt line 293 at r2 (raw file):

            horizontalArrangement = Arrangement.spacedBy(Dimens.mediumPadding)
        ) {
            Text(

So if the device name is either null or empty this will show as "Device name:". So I wonder if it would be better to just not show device name at all in that case or if that would break?

---

android/lib/model/src/main/kotlin/net/mullvad/mullvadvpn/model/AccountExpiry.kt line 12 at r1 (raw file):

    @Parcelize
    data class Available(val expiryDateTime: DateTime) : AccountExpiry() {
        override fun daysLeft(): Int =

This perhaps could be a more generic extension function for DateTime?

[Pururun]

Reviewed 4 of 5 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Rawa)

[Rawa]

Reviewable status: 36 of 63 files reviewed, 2 unresolved discussions (waiting on @Pururun)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/component/TopBar.kt line 293 at r2 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

So if the device name is either null or empty this will show as "Device name:". So I wonder if it would be better to just not show device name at all in that case or if that would break?

It would certainly work, I'd like us to use maybe something like "placeholder" in this case:
https://google.github.io/accompanist/placeholder/ . I think shimmer is a pretty easily applied affect to hind that the data is loading.

But that should then be aligned with the rest of the team and design before we apply something like that.

I've removed "Device name:" until the text have been loaded now, reason for still rendering the Text it self it to prevent "Time Left" to take it's place.

---

android/lib/model/src/main/kotlin/net/mullvad/mullvadvpn/model/AccountExpiry.kt line 12 at r1 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

This perhaps could be a more generic extension function for DateTime?

👍 Agree. Fixed.

[Pururun]

Reviewed 1 of 1 files at r3, 26 of 26 files at r4, 19 of 19 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Rawa)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/component/TopBar.kt line 293 at r2 (raw file):

Previously, Rawa (David Göransson) wrote…

It would certainly work, I'd like us to use maybe something like "placeholder" in this case:
https://google.github.io/accompanist/placeholder/ . I think shimmer is a pretty easily applied affect to hind that the data is loading.

But that should then be aligned with the rest of the team and design before we apply something like that.

I've removed "Device name:" until the text have been loaded now, reason for still rendering the Text it self it to prevent "Time Left" to take it's place.

I think it is at least something we should raise since it is something that is happening some times in the current implementation.

[Pururun]

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Rawa)

[Pururun]

Reviewed 3 of 3 files at r7, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Rawa)

[Pururun]

Reviewable status: complete! all files reviewed, all discussions resolved