Cache the transportStrategy in the UserDefaults

[buggmagnet]

This work was done in the ios-prepare-2023.4 branch, but was never back ported to main.
This PR fixes that.

---

This change is 

[linear]

IOS-341 Reintroduce caching the TransportStrategy in UserDefaults

We made a last minute improvement for the transport strategy in 2023.4. We should merge this to main to not lose these changes. The change resides in commit 2dbf59551.

[pinkisemils]

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @buggmagnet)

---

ios/MullvadTypes/AttemptsRecording.swift line 15 at r1 (raw file):

/// Used by `TransportStrategy` to record failed connection attempts in cache.
public protocol AttemptsRecording {
    func record(_ attempts: Int)

This method isn't called anywhere in this diff. Should this protocol exist?

[buggmagnet]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pinkisemils)

---

ios/MullvadTypes/AttemptsRecording.swift line 15 at r1 (raw file):

Previously, pinkisemils (Emīls Piņķis) wrote…

This method isn't called anywhere in this diff. Should this protocol exist?

It shouldnt, I thought I had deleted that file.
Thanks for catching it !

[pronebird]

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pronebird)

[pronebird]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @buggmagnet)

---

ios/PacketTunnel/PacketTunnelProvider/PacketTunnelProvider.swift line 44 at r1 (raw file):

        let shadowsocksCache = ShadowsocksConfigurationCache(cacheDirectory: containerURL)

        // This init cannot fail as long as the security group identifier is valid

Perhaps missing:

// swiftlint:disable:next force_cast

[pronebird]

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @buggmagnet)

---

ios/MullvadREST/RESTTransportStrategy.swift line 2 at r1 (raw file):

//
//  RESTTransportStrategy.swift

Mhm I think I renamed it with "REST" prefix a while ago.

---

ios/MullvadREST/RESTTransportStrategy.swift line 10 at r1 (raw file):

import Foundation
import MullvadTypes

Probably unused import.

[buggmagnet]

Reviewable status: 5 of 7 files reviewed, 4 unresolved discussions (waiting on @pinkisemils and @pronebird)

---

ios/MullvadREST/RESTTransportStrategy.swift line 2 at r1 (raw file):

Previously, pronebird (Andrej Mihajlov) wrote…

Mhm I think I renamed it with "REST" prefix a while ago.

Done

---

ios/MullvadREST/RESTTransportStrategy.swift line 10 at r1 (raw file):

Previously, pronebird (Andrej Mihajlov) wrote…

Probably unused import.

Done.

[buggmagnet]

Reviewable status: 5 of 7 files reviewed, 4 unresolved discussions (waiting on @pinkisemils and @pronebird)

---

ios/PacketTunnel/PacketTunnelProvider/PacketTunnelProvider.swift line 44 at r1 (raw file):

Previously, pronebird (Andrej Mihajlov) wrote…

Perhaps missing:

// swiftlint:disable:next force_cast

Huh that's odd, I don't get that warning either in the CLI, or in Xcode...
Thanks for catching that up. The same fix needs to be applied in AppDelegate too.

[buggmagnet]

Reviewable status: 5 of 7 files reviewed, 4 unresolved discussions (waiting on @pinkisemils and @pronebird)

---

ios/PacketTunnel/PacketTunnelProvider/PacketTunnelProvider.swift line 44 at r1 (raw file):

Previously, buggmagnet wrote…

Huh that's odd, I don't get that warning either in the CLI, or in Xcode...
Thanks for catching that up. The same fix needs to be applied in AppDelegate too.

Ok, the reason why this was not flagged up is twofold:

• This is not a force_cast but a force_unwrapping triggering example
• We did not enable force_unwrapping

As this code cannot possibly fail, I will leave it as is, and I opened a discussion about our use of force_unwrapping for our linter rules

[pinkisemils]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @pronebird)

[pronebird]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @pinkisemils)

[pinkisemils]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pronebird)

[pronebird]

Reviewable status: complete! all files reviewed, all discussions resolved

---

ios/PacketTunnel/PacketTunnelProvider/PacketTunnelProvider.swift line 44 at r1 (raw file):

Previously, buggmagnet wrote…

Ok, the reason why this was not flagged up is twofold:

• This is not a force_cast but a force_unwrapping triggering example
• We did not enable force_unwrapping

As this code cannot possibly fail, I will leave it as is, and I opened a discussion about our use of force_unwrapping for our linter rules

This can be tackled separately.