Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused code related to old ui #5270

Merged

Conversation

Pururun
Copy link
Contributor

@Pururun Pururun commented Oct 11, 2023

This change is Reviewable

@Pururun Pururun requested review from Rawa and sabercodic October 11, 2023 13:29
@linear
Copy link

linear bot commented Oct 11, 2023

@Pururun Pururun added the Android Issues related to Android label Oct 11, 2023
Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 62 of 62 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@sabercodic sabercodic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 62 of 62 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@sabercodic sabercodic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Pururun)


-- commits line 3 at r1:
Can this be changed to Remove usused classes and resources?

Code quote:

Remove unused classes. Remove unused resources

@Pururun Pururun force-pushed the remove-unused-code-related-to-old-ui-and-remove-baseline-des-402 branch from cb2e323 to 90334cd Compare October 12, 2023 07:48
Copy link
Contributor Author

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @albin-mullvad)


-- commits line 3 at r1:

Previously, albin-mullvad wrote…

Can this be changed to Remove usused classes and resources?

Of course. Done.

Copy link
Contributor

@sabercodic sabercodic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @albin-mullvad)

Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Pururun Pururun force-pushed the remove-unused-code-related-to-old-ui-and-remove-baseline-des-402 branch from 90334cd to 28f395e Compare October 12, 2023 12:01
@Pururun Pururun merged commit 5f0f746 into main Oct 12, 2023
@Pururun Pururun deleted the remove-unused-code-related-to-old-ui-and-remove-baseline-des-402 branch October 12, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants