Fix regression in OpenVPN monitor #5282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DES-404 OpenVPN monitor crashes on main
There's currently a panic when setting the tunnel protocol to |
dlon
force-pushed
the
openvpn-mon-async
branch
2 times, most recently
from
b77b02f to
cf48e51
Compare
MarkusPettersson98
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
Reviewed 1 of 3 files at r1, 1 of 2 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
MarkusPettersson98
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
Reviewed 3 of 3 files at r4, all commit messages.
Reviewable status:
MarkusPettersson98
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
Reviewed 3 of 3 files at r5, all commit messages.
Reviewable status:
dlon
force-pushed
the
openvpn-mon-async
branch
from
e62f1da to
7f8b7e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
main-- the openvpn monitor panics. This seems to be a regression due to the recent cleanup.waitfunctions are all async now. There are no calls toblock_on, etc.Close DES-404.
This change is