Use custom flavor endpoints #5294
Conversation
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @albin-mullvad)
android/service/src/main/kotlin/net/mullvad/mullvadvpn/service/di/ApiEndpointModule.kt line 13 at r1 (raw file):
single { if (BuildConfig.FLAVOR_infrastructure != "prod") { CustomApiEndpointConfiguration(BuildConfig.API_ENDPOINT, 443)
Just to make sure since this is a bit of a magic number:
Should we switch this number to either a build config or a defined constant? I guess this might be useful in the future.
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @albin-mullvad)
There was a problem hiding this comment.
Reviewable status: 5 of 7 files reviewed, all discussions resolved (waiting on @Pururun)
android/service/src/main/kotlin/net/mullvad/mullvadvpn/service/di/ApiEndpointModule.kt line 13 at r1 (raw file):
Previously, Pururun (Jonatan Rhodin) wrote…
Just to make sure since this is a bit of a magic number:
Should we switch this number to either a build config or a defined constant? I guess this might be useful in the future.
Add a constant!
added* 😆 |
There was a problem hiding this comment.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
albin-mullvad
force-pushed
the
use-custom-flavor-endpoints
branch
from
acdbaa3 to
55099af
Compare
This PR aims to use custom flavor endpoints for development and testing.
This change is