Do not show change log when it is empty

[rablador]

When there are no meaningful changes we do not want to advertise anything in the app.

---

This change is 

[linear]

IOS-346 Stop showing the changelog to users when it is empty

When there are no meaningful changes we want to advertise in the app.

[buggmagnet]

Reviewed all commit messages.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @rablador)

---

ios/MullvadVPN/Coordinators/ApplicationCoordinator.swift line 998 at r1 (raw file):

fileprivate extension AppPreferencesDataSource {
    var isSeenLatestChanges: Bool {

Can we rename this hasSeenLastChanges ?

[buggmagnet]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @rablador)

---

ios/MullvadVPN/Coordinators/ApplicationCoordinator.swift line 998 at r1 (raw file):

Previously, buggmagnet wrote…

Can we rename this hasSeenLastChanges ?

Or hasSeenLastChangelog

[buggmagnet]

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @rablador)

---

ios/MullvadVPN/Coordinators/ApplicationCoordinator.swift line 998 at r1 (raw file):

Previously, buggmagnet wrote…

Or hasSeenLastChangelog

With the other suggestion, we can simplify this to the following (which is IMHO way easier to understand)

var hasSeenLastChanges: Bool {
    ChangeLogInteractor().hasNewChanges() ||
    lastSeenChangeLogVersion != Bundle.main.shortVersion
}

---

ios/MullvadVPN/View controllers/ChangeLog/ChangeLogInteractor.swift line 14 at r1 (raw file):

final class ChangeLogInteractor {
    private let logger = Logger(label: "ChangeLogInteractor")
    private(set) var items: [String] = []

We shouldn't be exposing the guts of the ChangeLogInteractor for no reason.
Instead, it should say itself whether there are changes or not.

here's a suggestion

public func hasNewChanges() -> Bool {
    items.isEmpty == false
}

[buggmagnet]

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @rablador)

---

ios/MullvadVPN/Coordinators/ApplicationCoordinator.swift line 998 at r1 (raw file):

Previously, buggmagnet wrote…

With the other suggestion, we can simplify this to the following (which is IMHO way easier to understand)

var hasSeenLastChanges: Bool {
    ChangeLogInteractor().hasNewChanges() ||
    lastSeenChangeLogVersion != Bundle.main.shortVersion
}

Correction

var hasSeenLastChanges: Bool {
    ChangeLogInteractor().hasNewChanges() == false &&
    lastSeenChangeLogVersion == Bundle.main.shortVersion
}

[rablador]

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @buggmagnet)

---

ios/MullvadVPN/Coordinators/ApplicationCoordinator.swift line 998 at r1 (raw file):

Previously, buggmagnet wrote…

With the other suggestion, we can simplify this to the following (which is IMHO way easier to understand)

var hasSeenLastChanges: Bool {
    ChangeLogInteractor().hasNewChanges() ||
    lastSeenChangeLogVersion != Bundle.main.shortVersion
}

Indeed, much better!

---

ios/MullvadVPN/View controllers/ChangeLog/ChangeLogInteractor.swift line 14 at r1 (raw file):

Previously, buggmagnet wrote…

We shouldn't be exposing the guts of the ChangeLogInteractor for no reason.
Instead, it should say itself whether there are changes or not.

here's a suggestion

public func hasNewChanges() -> Bool {
    items.isEmpty == false
}

I can meet you just past halfway.

[buggmagnet]

Reviewed 1 of 2 files at r3, all commit messages.
Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @rablador)

---

ios/MullvadVPN/Coordinators/ApplicationCoordinator.swift line 998 at r1 (raw file):

Previously, rablador (Jon Petersson) wrote…

Indeed, much better!

The parenthesis were not necessary. But not the end of the world.