Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IPv6 info dialog #5303

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

raksooo
Copy link
Member

@raksooo raksooo commented Oct 16, 2023

This PR adds an info dialog to the "Enable IPv6" feature and removes the now redundant footer text.


This change is Reviewable

@linear
Copy link

linear bot commented Oct 16, 2023

DES-212 Add information dialog to "Enable IPv6" feature

Add information ℹ️ dialog to the Enable IPv6 setting in the desktop GUI. Richard says that many users don't understand what it does and if they need it. The truth is that most people don't need this, and if a user don't know what it does, they most likely don't need it.

Text inside dialog:


When this feature is enabled, IPv6 can be used alongside IPv4 in the VPN tunnel to communicate with internet services.

IPv4 is always enabled and the majority of websites and applications use this protocol. We do not recommend enabling IPv6 unless you know you need it.


Zeplin: https://zpl.io/Z0GDlnJ

Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@raksooo raksooo force-pushed the add-information-dialog-to-enable-ipv6-feature-des-212 branch 2 times, most recently from 73bd571 to 9756323 Compare October 17, 2023 12:19
@raksooo raksooo force-pushed the add-information-dialog-to-enable-ipv6-feature-des-212 branch from 9756323 to d1be0d3 Compare October 17, 2023 12:46
@raksooo raksooo merged commit eb5791d into main Oct 17, 2023
4 checks passed
@raksooo raksooo deleted the add-information-dialog-to-enable-ipv6-feature-des-212 branch October 17, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants