Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the dpad navigation & dialog styles #5307

Conversation

Rawa
Copy link
Contributor

@Rawa Rawa commented Oct 17, 2023

  • Fixes DPAD navigation in dialogs
  • Aligns dialog designs to use Alert Dialog
  • Introduces mullvadDarkTextFieldColors
  • Fixes textfield width on wide devices

This change is Reviewable

@linear
Copy link

linear bot commented Oct 17, 2023

DROID-401 Investigate and fix the DPAD navigation bug on Alert Dialog

There needs double up/down DPAD clicks on alert dialog to reach stuff for the first time.

@Rawa Rawa self-assigned this Oct 17, 2023
@Rawa Rawa added the Android Issues related to Android label Oct 17, 2023
@Rawa Rawa requested review from albin-mullvad, Pururun and sabercodic and removed request for albin-mullvad October 17, 2023 14:17
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it and it works much better. However when I try with dpad on an emulator there is inconsistent behaviour when comparing the input field of redeem voucher and all other dialogues. Is this intended and can you see this different behaviour on the TV?

Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Rawa Rawa force-pushed the investigate-and-fix-the-dpad-navigation-bug-on-alert-dialog-droid-401 branch from 46ed9ff to fd9a150 Compare October 18, 2023 11:53
Copy link
Contributor Author

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A great remark, there was a box surrounding the RedeemVoucherDialog, does it work better now? :)

Reviewable status: 1 of 10 files reviewed, all discussions resolved (waiting on @Pururun)

@Rawa Rawa force-pushed the investigate-and-fix-the-dpad-navigation-bug-on-alert-dialog-droid-401 branch 2 times, most recently from 1129200 to bed34f3 Compare October 20, 2023 09:45
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great. :)
:lgtm:

Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@sabercodic sabercodic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Rawa Rawa force-pushed the investigate-and-fix-the-dpad-navigation-bug-on-alert-dialog-droid-401 branch from bed34f3 to f0e3d0e Compare October 23, 2023 13:29
@Pururun Pururun merged commit 1104b74 into main Oct 23, 2023
12 checks passed
@Pururun Pururun deleted the investigate-and-fix-the-dpad-navigation-bug-on-alert-dialog-droid-401 branch October 23, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants