-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the dpad navigation & dialog styles #5307
Fix the dpad navigation & dialog styles #5307
Conversation
DROID-401 Investigate and fix the DPAD navigation bug on Alert Dialog
There needs double up/down DPAD clicks on alert dialog to reach stuff for the first time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it and it works much better. However when I try with dpad on an emulator there is inconsistent behaviour when comparing the input field of redeem voucher and all other dialogues. Is this intended and can you see this different behaviour on the TV?
Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
46ed9ff
to
fd9a150
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A great remark, there was a box surrounding the RedeemVoucherDialog, does it work better now? :)
Reviewable status: 1 of 10 files reviewed, all discussions resolved (waiting on @Pururun)
1129200
to
bed34f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
bed34f3
to
f0e3d0e
Compare
This change is