Replace EXTERNAL_STORAGE permissions on android api level 33+

[sabercodic]

Add new permission instead of READ/WRITE _EXTERNAL_STORAGE on android api level 33+.

This change is 

[linear]

DROID-367 Remove WRITE_EXTERNAL_STORAGE permission for android 13+

READ/WRITE EXTERNAL_STORAGE is used in two places:

• "test" module use this permissions to access screenshots folder and sqlite files
• "app" module on debug mode

[albin-mullvad]

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @sabercodic)

---

android/test/e2e/src/main/kotlin/net/mullvad/mullvadvpn/test/e2e/EndToEndTest.kt line 29 at r1 (raw file):

    val permissionRule: GrantPermissionRule =
        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) {
            GrantPermissionRule.grant(Manifest.permission.READ_MEDIA_IMAGES)

This doesn't look correct since:

• We don't use storage for images.
• Any change like this would required some sort of data migration logic. Or is that not the case?

Code quote:

READ_MEDIA_IMAGES

[albin-mullvad]

Is it for 13+ or 14+? The Linear issue and PR says different things.

Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @sabercodic)

---

-- commits line 2 at r1:
Can you clarify what this fixes in the commit message?

Code quote:

Fix InlinedApi lint issue

---

android/test/e2e/src/main/kotlin/net/mullvad/mullvadvpn/test/e2e/EndToEndTest.kt line 29 at r1 (raw file):

Previously, albin-mullvad wrote…

This doesn't look correct since:

• We don't use storage for images.
• Any change like this would required some sort of data migration logic. Or is that not the case?

Sorry NVM, I confused this with also being used outside of the e2e/debug code.

[albin-mullvad]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @sabercodic)

a discussion (no related file):
Has this been verified to work on both newer and older API levels? Our tests run on API levels back to version 26.

---

---

-- commits line 2 at r1:

Previously, albin-mullvad wrote…

Can you clarify what this fixes in the commit message?

Also clarify the PR title 🙏

[albin-mullvad]

Reviewed all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @sabercodic)

[sabercodic]

13+

Reviewable status: 3 of 4 files reviewed, 2 unresolved discussions (waiting on @albin-mullvad)

---

-- commits line 2 at r1:

Previously, albin-mullvad wrote…

Also clarify the PR title 🙏

Done.

[albin-mullvad]

I also updated the PR description since it was outdated

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @sabercodic)

[albin-mullvad]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @sabercodic)

a discussion (no related file):

Previously, albin-mullvad wrote…

Has this been verified to work on both newer and older API levels? Our tests run on API levels back to version 26.

@sabercodic ping! Did you verify that this works as expected both on the range of supported API levels?

---

[albin-mullvad]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @sabercodic)

a discussion (no related file):

Previously, albin-mullvad wrote…

@sabercodic ping! Did you verify that this works as expected both on the range of supported API levels?

^ both

---

[albin-mullvad]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @sabercodic)

a discussion (no related file):

Previously, albin-mullvad wrote…

^ both

@sabercodic ping!

---

[sabercodic]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @albin-mullvad)

a discussion (no related file):

Previously, albin-mullvad wrote…

@sabercodic ping!

Yes I verified. Tested on different api levels from 26 to 34

---

[albin-mullvad]

Reviewable status: complete! all files reviewed, all discussions resolved