Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload End-to-end test report matrix to Github Actions #5347

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

MarkusPettersson98
Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 commented Oct 23, 2023

Upload e2e-test report matrix as an .html file and submit it to github actions job summary: https://github.blog/2022-05-09-supercharging-github-actions-with-job-summaries/

Example test run: https://github.com/mullvad/mullvadvpn-app/actions/runs/6615036798


This change is Reviewable

Copy link
Member

@dlon dlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MarkusPettersson98)


.github/workflows/desktop-e2e.yml line 23 at r1 (raw file):

          ./test/ci-runtests.sh ${{ matrix.os }}
      - uses: actions/upload-artifact@v3
        if: '!cancelled()'

Why is if: !cancelled() necessary? Is this so that it runs even when the previous step fails?


.github/workflows/desktop-e2e.yml line 87 at r1 (raw file):

          # "Unpack" the downloaded report artifacts: https://github.com/actions/download-artifact/issues/141
          cp ./.ci-logs/artifacts/*_report/*_report ./.ci-logs/
          cargo run --bin test-manager format-test-reports ./.ci-logs/*_report | tee summary.html >> $GITHUB_STEP_SUMMARY

That's awesome. I had no idea it was this simple :)

Copy link
Contributor Author

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dlon)


.github/workflows/desktop-e2e.yml line 23 at r1 (raw file):

Previously, dlon (David Lönnhager) wrote…

Why is if: !cancelled() necessary? Is this so that it runs even when the previous step fails?

Exactly, but the step should be manually cancellable. See https://github.com/orgs/community/discussions/25789 for an explanation :)


.github/workflows/desktop-e2e.yml line 87 at r1 (raw file):

Previously, dlon (David Lönnhager) wrote…

That's awesome. I had no idea it was this simple :)

:D

@MarkusPettersson98 MarkusPettersson98 force-pushed the github-actions/generate-test-report-matrix branch 2 times, most recently from 98c8737 to 0913147 Compare October 24, 2023 07:43
Upload e2e-test report matrix as an `.html` file and submit it to github
actions job summary: https://github.blog/2022-05-09-supercharging-github-actions-with-job-summaries/
@MarkusPettersson98 MarkusPettersson98 force-pushed the github-actions/generate-test-report-matrix branch from 0913147 to a01462d Compare October 24, 2023 08:05
@MarkusPettersson98 MarkusPettersson98 merged commit 8e4d750 into main Oct 24, 2023
26 checks passed
@MarkusPettersson98 MarkusPettersson98 deleted the github-actions/generate-test-report-matrix branch October 24, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants