Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax relay location constraints in some end-to-end tests #5351

Merged
merged 4 commits into from
Oct 24, 2023

Conversation

MarkusPettersson98
Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 commented Oct 24, 2023

Clean up some older test cases:

  • relax (too restrictive) relay location constraints
  • Use types from mullvad_types instead of the auto-generated gRPC types. These are generally easier to work with, and reflects how code in the rest of the app is written.
  • Add some docs à la boy scout rule

This change is Reviewable

@MarkusPettersson98 MarkusPettersson98 changed the title Relay relay location constraints in some end-to-end tests Relax relay location constraints in some end-to-end tests Oct 24, 2023
Copy link
Member

@dlon dlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@MarkusPettersson98 MarkusPettersson98 force-pushed the fix-tests/relay-location-constraints branch from d3241a0 to b0a2ea3 Compare October 24, 2023 09:35
@MarkusPettersson98 MarkusPettersson98 merged commit a8bd286 into main Oct 24, 2023
28 checks passed
@MarkusPettersson98 MarkusPettersson98 deleted the fix-tests/relay-location-constraints branch October 24, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants