Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round textfield unless showing dropdown #5353

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

Rawa
Copy link
Contributor

@Rawa Rawa commented Oct 24, 2023


This change is Reviewable

@Rawa Rawa requested a review from Pururun October 24, 2023 08:54
@linear
Copy link

linear bot commented Oct 24, 2023

DROID-370 Determine compose TextFieldColors

We should create a default implementation (in agreement with matilda ) of TextFieldColors where we implement all the colors we want for a textfield.

Usages:

  • Report Problem (Light background)
  • View Logs (Light background)
  • Login
  • Set Mtu Dialog

@Rawa Rawa self-assigned this Oct 24, 2023
@Rawa Rawa added the Android Issues related to Android label Oct 24, 2023
@Rawa Rawa force-pushed the determine-compose-textfieldcolors-droid-370 branch 2 times, most recently from 4a064a2 to d1c00fc Compare October 24, 2023 08:58
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I tested it on my phone, the bottom left and right corner always loses its corner radius when the text field is selected, regardless if the dropdown is showing or not.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Rawa Rawa force-pushed the determine-compose-textfieldcolors-droid-370 branch from d1c00fc to 710b7f9 Compare October 25, 2023 14:34
Copy link
Contributor Author

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you verify that it works now? I believe i fixed. Also updated unfocused label colors as well.

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @Pururun)

Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah look fine now.

Reviewable status: 0 of 2 files reviewed, all discussions resolved

Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Pururun Pururun force-pushed the determine-compose-textfieldcolors-droid-370 branch from 710b7f9 to 57d93a4 Compare October 26, 2023 12:48
@Pururun Pururun merged commit 0655856 into main Oct 26, 2023
10 checks passed
@Pururun Pururun deleted the determine-compose-textfieldcolors-droid-370 branch October 26, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants