-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Round textfield unless showing dropdown #5353
Conversation
DROID-370 Determine compose TextFieldColors
We should create a default implementation (in agreement with matilda ) of TextFieldColors where we implement all the colors we want for a textfield. Usages:
|
4a064a2
to
d1c00fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I tested it on my phone, the bottom left and right corner always loses its corner radius when the text field is selected, regardless if the dropdown is showing or not.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
d1c00fc
to
710b7f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you verify that it works now? I believe i fixed. Also updated unfocused label colors as well.
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @Pururun)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah look fine now.
Reviewable status: 0 of 2 files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
710b7f9
to
57d93a4
Compare
This change is