Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update privacy strings #5356

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Conversation

Rawa
Copy link
Contributor

@Rawa Rawa commented Oct 24, 2023

We had an invalid privacy policy string that contained \n our translations-converter tool does not support this. This PR fixes this string.


This change is Reviewable

@linear
Copy link

linear bot commented Oct 24, 2023

DROID-368 Broken translations converter script

For example, every time you run the translations converter it will add the string:

rawaDavids-MacBook-Pro ➜  translations-converter git:(add-device-name-to-create-account-flow-droid-93) cargo run
Finished dev [unoptimized + debuginfo] target(s) in 0.07s

 Running `/Users/rawa/Code/mullvadvpn-app/target/debug/translations-converter`
Appending missing translations to template file:

privacy_disclaimer_body: To make sure that you have the most secure version and to inform you of any issues with the current version that is running, the app performs version checks automatically. This sends the app version and Android system version to Mullvad servers. Mullvad keeps counters on number of used app versions and Android versions. The data is never stored or used in any way that can identify you.\n\nIf the split tunneling feature is used, then the app queries your system for a list of all installed applications. This list is only retrieved in the split tunneling view. The list of installed applications is never sent from the device.

Steps to reproduce:

  1. go to android/translations_converter
  2. cargo run
  3. See string get added
  4. cargo run
  5. See string get added again

Update:

Looks like the script might have bee broken by the following PR: #4419

Please double check if that's the case before continuing the investigation.

@Rawa Rawa force-pushed the broken-translations-converter-script-droid-368 branch 2 times, most recently from facf6d1 to 43fa663 Compare October 24, 2023 14:37
@Rawa Rawa requested a review from Pururun October 24, 2023 14:49
@Rawa Rawa self-assigned this Oct 24, 2023
@Rawa Rawa added the Android Issues related to Android label Oct 25, 2023
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 4 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Pururun Pururun force-pushed the broken-translations-converter-script-droid-368 branch from 43fa663 to 77637a1 Compare October 26, 2023 08:27
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Pururun Pururun merged commit 780308c into main Oct 26, 2023
17 checks passed
@Pururun Pururun deleted the broken-translations-converter-script-droid-368 branch October 26, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants