Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getDevice method signature #5365

Merged

Conversation

Rawa
Copy link
Contributor

@Rawa Rawa commented Oct 26, 2023

As part of a timeboxed issue I looked through Play Store crashes and found that we have the wrong signature on this JNI calling function.


This change is Reviewable

@linear
Copy link

linear bot commented Oct 26, 2023

@Rawa Rawa self-assigned this Oct 26, 2023
@Rawa Rawa added the Android Issues related to Android label Oct 26, 2023
@Rawa Rawa force-pushed the nullpointerexception-on-devicestatetoken-droid-462 branch from 00312d3 to 6e607ab Compare October 26, 2023 07:55
Copy link
Contributor Author

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion


android/service/src/main/kotlin/net/mullvad/mullvadvpn/service/ForegroundNotificationManager.kt line 63 at r1 (raw file):

                daemon
                    ?.deviceStateUpdates
                    ?.onStart { daemon.getAndEmitDeviceState()?.let { emit(it) } }

Not sure how you guys feel about this one? Maybe a bit fail silent? We could also go for !! and just let it crash like before.

Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved


android/service/src/main/kotlin/net/mullvad/mullvadvpn/service/ForegroundNotificationManager.kt line 63 at r1 (raw file):

Previously, Rawa (David Göransson) wrote…

Not sure how you guys feel about this one? Maybe a bit fail silent? We could also go for !! and just let it crash like before.

Let's go ahead with this one!

@albin-mullvad albin-mullvad force-pushed the nullpointerexception-on-devicestatetoken-droid-462 branch from 6e607ab to c06aba6 Compare November 17, 2023 12:30
Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@albin-mullvad albin-mullvad merged commit 8620efd into main Nov 17, 2023
13 checks passed
@albin-mullvad albin-mullvad deleted the nullpointerexception-on-devicestatetoken-droid-462 branch November 17, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants