-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix getDevice method signature #5365
Fix getDevice method signature #5365
Conversation
DROID-462 NullPointerException on DeviceState.token()
Seems like we can get null pointer on DeviceState.token(), this is not handled correctly. |
00312d3
to
6e607ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion
android/service/src/main/kotlin/net/mullvad/mullvadvpn/service/ForegroundNotificationManager.kt
line 63 at r1 (raw file):
daemon ?.deviceStateUpdates ?.onStart { daemon.getAndEmitDeviceState()?.let { emit(it) } }
Not sure how you guys feel about this one? Maybe a bit fail silent? We could also go for !!
and just let it crash like before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
android/service/src/main/kotlin/net/mullvad/mullvadvpn/service/ForegroundNotificationManager.kt
line 63 at r1 (raw file):
Previously, Rawa (David Göransson) wrote…
Not sure how you guys feel about this one? Maybe a bit fail silent? We could also go for
!!
and just let it crash like before.
Let's go ahead with this one!
6e607ab
to
c06aba6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
As part of a timeboxed issue I looked through Play Store crashes and found that we have the wrong signature on this JNI calling function.
This change is