Fix view logs crash

[Rawa]

Fixes crash that could happen if we render too many lines in the textfield.

---

This change is 

[linear]

DROID-460 View logs crash because of long log

We should replace the log view with a Lazy Column instead of a TextField due to long input in textfield may crash the app. This will have to disable the copy of the logs due to limitations in SelectableContainer.

[Pururun]

This fixes the issue, however we no longer give the user the ability to download or copy the app logs. So I guess someone with more knowledge about how the users uses or are expected to use the app should confirm that we are not removing an expected feature.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

[Rawa]

That is correct, but considering that some users can't copy because it would crash immediately it might be our only way? We could also consider offering a copy button or similar to that.

Reviewable status: complete! all files reviewed, all discussions resolved

[Pururun]

I think we should raise the issue with Matilda and propose to add a button that allows the user to share/download the logs.

Reviewable status: complete! all files reviewed, all discussions resolved

[Rawa]

I've messages design now, to see how they feel about resolving this.

Reviewable status: complete! all files reviewed, all discussions resolved

[Rawa]

After internal discussions we have now added a share button that has the option to copy and share the content of the logs.

Reviewable status: 1 of 6 files reviewed, all discussions resolved (waiting on @Pururun)

[albin-mullvad]

Nice improvement with the share button!

Reviewed 1 of 3 files at r1, 5 of 5 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Rawa)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/ViewLogsScreen.kt line 71 at r2 (raw file):

                navigationIcon = { NavigateBackIconButton(onBackClick) },
                actions = {
                    IconButton(onClick = { shareLogs(uiState.allLines.joinToString("\n")) }) {

Do we need to make this call both here and in the shareLogs function or can we call it in a single place?

Code quote:

uiState.allLines.joinToString("\n")

[Rawa]

Reviewable status: 5 of 6 files reviewed, 1 unresolved discussion (waiting on @albin-mullvad)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/ViewLogsScreen.kt line 71 at r2 (raw file):

Previously, albin-mullvad wrote…

Do we need to make this call both here and in the shareLogs function or can we call it in a single place?

Nice catch, my mistake, I was suppose to use uiState.text() I fixed this issue and refactored out shareLogs function

[Pururun]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @albin-mullvad)

[albin-mullvad]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/ViewLogsScreen.kt line 71 at r2 (raw file):

Previously, Rawa (David Göransson) wrote…

Nice catch, my mistake, I was suppose to use uiState.text() I fixed this issue and refactored out shareLogs function

👍