Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split tunneling UI fixes #5386

Merged
merged 3 commits into from
Nov 8, 2023
Merged

Split tunneling UI fixes #5386

merged 3 commits into from
Nov 8, 2023

Conversation

Rawa
Copy link
Contributor

@Rawa Rawa commented Oct 31, 2023 •
edited by faern
Loading

  • Fixes duplicate dividers
  • Adds alpha to the buttons
  • Updates tunneling description according to design.

This change is Reviewable

@Rawa Rawa added the Android Issues related to Android label Oct 31, 2023
@Rawa Rawa requested a review from Pururun October 31, 2023 08:22
@Rawa Rawa self-assigned this Oct 31, 2023
@linear
Copy link

linear bot commented Oct 31, 2023

DROID-457 Split tunneling ui fixes

  • +/- does not have any alpha
  • Description is not aligned with Design
  • Divider is different between elements

@Rawa Rawa force-pushed the split-tunneling-ui-fixes-droid-457 branch from add0304 to f8b5dcf Compare October 31, 2023 08:26
@Rawa Rawa requested a review from sabercodic October 31, 2023 08:28
@Rawa Rawa force-pushed the split-tunneling-ui-fixes-droid-457 branch from f8b5dcf to 7c67c4b Compare October 31, 2023 08:29
sabercodic
sabercodic approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@sabercodic sabercodic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 22 of 22 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Rawa Rawa force-pushed the split-tunneling-ui-fixes-droid-457 branch 2 times, most recently from df5bc13 to f665c45 Compare October 31, 2023 12:35
Pururun
Pururun approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Pururun Pururun force-pushed the split-tunneling-ui-fixes-droid-457 branch from f665c45 to df3bf00 Compare November 6, 2023 12:20
@Pururun Pururun force-pushed the split-tunneling-ui-fixes-droid-457 branch from df3bf00 to a2b5051 Compare November 8, 2023 10:17
@Pururun Pururun merged commit 8f7b581 into main Nov 8, 2023
14 checks passed
@Pururun Pururun deleted the split-tunneling-ui-fixes-droid-457 branch November 8, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabercodic sabercodic sabercodic approved these changes

@Pururun Pururun Pururun approved these changes

Assignees

@Rawa Rawa

Labels
Android Issues related to Android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rawa @Pururun @sabercodic