-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix button highlight and refactor screen #5387
Conversation
DROID-470 Too many devices remove button
Button to delete devices on "Too Many Devices" page is not a icon button, this causes the touch target and ripple to be off. We should replace it with a proper Icon button |
65f416b
to
76c822e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Rawa)
android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/DeviceListScreen.kt
line 247 at r1 (raw file):
Icon( painter = painterResource(id = R.drawable.icon_close), contentDescription = "Remove",
Should this be hardcoded? I think we can use R.string.remove_button
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @Pururun)
android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/DeviceListScreen.kt
line 247 at r1 (raw file):
Previously, Pururun (Jonatan Rhodin) wrote…
Should this be hardcoded? I think we can use
R.string.remove_button
instead.
It got carried over from the old button when refactoring, I've changed to use the content description of the remove button now which has a matching string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @Pururun)
android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/DeviceListScreen.kt
line 247 at r1 (raw file):
Previously, Rawa (David Göransson) wrote…
It got carried over from the old button when refactoring, I've changed to use the content description of the remove button now which has a matching string.
Done.
dcbdbc3
to
5648a77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 3 files at r1, 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
07bb6c4
to
2f35a14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
2f35a14
to
64e2a2c
Compare
This change is