-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for app languages #5389
Conversation
b1aefb5
to
69ec0fb
Compare
69ec0fb
to
ade7dfe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Rawa)
CHANGELOG.md
line 49 at r1 (raw file):
- Migrate voucher dialog to compose. - Add "New Device" in app notification & rework notification system - Add support for App Languages
Can this be clarified a bit? Perhaps something like:
- Add support for setting per-app language in system settings.
Code quote:
Add support for App Languages
ade7dfe
to
bc794da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @albin-mullvad and @Pururun)
CHANGELOG.md
line 49 at r1 (raw file):
Previously, albin-mullvad wrote…
Can this be clarified a bit? Perhaps something like:
- Add support for setting per-app language in system settings.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
bc794da
to
21f6811
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
This PR adds the support for app languages. It uses the automatic way of adding languages:
https://developer.android.com/guide/topics/resources/app-languages#auto-localeconfig
If we want more finer control, we can add a custom list of languages but that would also require us to maintain that list.
This change is