Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for app languages #5389

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

Rawa
Copy link
Contributor

@Rawa Rawa commented Nov 1, 2023

This PR adds the support for app languages. It uses the automatic way of adding languages:
https://developer.android.com/guide/topics/resources/app-languages#auto-localeconfig

If we want more finer control, we can add a custom list of languages but that would also require us to maintain that list.


This change is Reviewable

Copy link

linear bot commented Nov 1, 2023

@Rawa Rawa force-pushed the add-support-for-app-languages-droid-471 branch from b1aefb5 to 69ec0fb Compare November 1, 2023 08:04
@Rawa Rawa self-assigned this Nov 1, 2023
@Rawa Rawa added the Android Issues related to Android label Nov 1, 2023
@Rawa Rawa requested review from albin-mullvad and Pururun November 1, 2023 08:08
@Rawa Rawa force-pushed the add-support-for-app-languages-droid-471 branch from 69ec0fb to ade7dfe Compare November 1, 2023 08:21
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Rawa)


CHANGELOG.md line 49 at r1 (raw file):

- Migrate voucher dialog to compose.
- Add "New Device" in app notification & rework notification system
- Add support for App Languages

Can this be clarified a bit? Perhaps something like:

 - Add support for setting per-app language in system settings.

Code quote:

 Add support for App Languages

@Rawa Rawa force-pushed the add-support-for-app-languages-droid-471 branch from ade7dfe to bc794da Compare November 10, 2023 08:15
Copy link
Contributor Author

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @albin-mullvad and @Pururun)


CHANGELOG.md line 49 at r1 (raw file):

Previously, albin-mullvad wrote…

Can this be clarified a bit? Perhaps something like:

 - Add support for setting per-app language in system settings.

Done.

Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@albin-mullvad albin-mullvad force-pushed the add-support-for-app-languages-droid-471 branch from bc794da to 21f6811 Compare November 10, 2023 10:36
Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@albin-mullvad albin-mullvad merged commit 68ec03b into main Nov 10, 2023
7 checks passed
@albin-mullvad albin-mullvad deleted the add-support-for-app-languages-droid-471 branch November 10, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants