-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove broken test and speed up iOS CI #5390
Conversation
9c321d1
to
b0bd2ba
Compare
5ca3420
to
23266dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe
Reviewed 2 of 2 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pinkisemils)
.github/workflows/ios.yml
line 68 at r1 (raw file):
- name: Set up yeetd to workaround XCode being slow in CI run: | wget https://github.com/biscuitehh/yeetd/releases/download/1.0/yeetd-normal.pkg
Don't know where you found this, but that's a pretty cool find !
Have you confirmed that yeetd
won't get killed before the tests start ?
I've seen people struggle with long running processes, and there is a solution to go around that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @buggmagnet)
.github/workflows/ios.yml
line 68 at r1 (raw file):
Previously, buggmagnet wrote…
Don't know where you found this, but that's a pretty cool find !
Have you confirmed that
yeetd
won't get killed before the tests start ?
I've seen people struggle with long running processes, and there is a solution to go around that.
The only thing I know and the only thing I really care about is that without yeetd
, the tests run far slower. I found it when looking through GitHub's issues about Xcode unit tests being slow. For now, I don't think we must worry about this.
4f4bd46
to
9fe2278
Compare
9fe2278
to
1316052
Compare
1316052
to
7704e46
Compare
This is me trying to fix GitHub CI issues, by following some random dude on the internet. actions/runner-images#8651 (comment)
In addition to that, I have switched over to M1 instances, which are significantly faster and have more cores and I have chosen to remove the faulty test as per @buggmagnet instructions.
This change is