Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broken test and speed up iOS CI #5390

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Remove broken test and speed up iOS CI #5390

merged 2 commits into from
Nov 10, 2023

Conversation

pinkisemils
Copy link
Collaborator

@pinkisemils pinkisemils commented Nov 1, 2023

This is me trying to fix GitHub CI issues, by following some random dude on the internet. actions/runner-images#8651 (comment)

In addition to that, I have switched over to M1 instances, which are significantly faster and have more cores and I have chosen to remove the faulty test as per @buggmagnet instructions.


This change is Reviewable

@pinkisemils pinkisemils added the iOS Issues related to iOS label Nov 8, 2023
@pinkisemils pinkisemils changed the title Use yeetd to help slowness Remove broken test and speed up iOS CI Nov 9, 2023
@pinkisemils pinkisemils marked this pull request as ready for review November 9, 2023 14:37
Copy link
Contributor

@pronebird pronebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pinkisemils)


.github/workflows/ios.yml line 68 at r1 (raw file):

      - name: Set up yeetd to workaround XCode being slow in CI
        run: |
          wget https://github.com/biscuitehh/yeetd/releases/download/1.0/yeetd-normal.pkg

Don't know where you found this, but that's a pretty cool find !

Have you confirmed that yeetd won't get killed before the tests start ?
I've seen people struggle with long running processes, and there is a solution to go around that.

Copy link
Collaborator Author

@pinkisemils pinkisemils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @buggmagnet)


.github/workflows/ios.yml line 68 at r1 (raw file):

Previously, buggmagnet wrote…

Don't know where you found this, but that's a pretty cool find !

Have you confirmed that yeetd won't get killed before the tests start ?
I've seen people struggle with long running processes, and there is a solution to go around that.

The only thing I know and the only thing I really care about is that without yeetd, the tests run far slower. I found it when looking through GitHub's issues about Xcode unit tests being slow. For now, I don't think we must worry about this.

@buggmagnet buggmagnet force-pushed the fix-gh-ios-slow branch 2 times, most recently from 4f4bd46 to 9fe2278 Compare November 10, 2023 12:52
@pinkisemils pinkisemils merged commit 73c8948 into main Nov 10, 2023
5 checks passed
@pinkisemils pinkisemils deleted the fix-gh-ios-slow branch November 10, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS Issues related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants