Add support for links in markdown #5406
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR revamps the markdown parser which previously was limited to supporting bold text and paragraphs, but with this PR it gets extended to support links too. Our previous implementation was very simple and to support links I had to make a more formal parser.
The syntax for links looks as following:
Typically
NSAttributedString
usesNSLinkAttributeName
attribute to highlight links within the attributed string, however when such attribute is used withUILabel
, the color of the link is impossible to change as it's somehow fixed to default blue.MarkdownStylingOptions
offers a way to customize the attribute that's being used, a custom.hyperlink
attribute is offered as alternative.Standard link attribute with custom
UILabel
supporting touch on links:Custom hyperlink attribute with custom
UILabel
supporting touch on links:This change is