-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix-font-weights-in-the-device-revoked-view-ios-377 #5407
fix-font-weights-in-the-device-revoked-view-ios-377 #5407
Conversation
IOS-377 Fix spacing and font weights in the "Device revoked" view
Currently, the fonts used are a bit too light in the revoked view, it is clear the view isn't following our design. This is what it looks like now: And this is what it should look like: Devices Revoked device Not connected.png Zeplin: https://app.zeplin.io/project/5f928a32fdc9962af9018d70/screen/619ccb73bb9774163fbbce96 Confluence: https://mullvad.atlassian.net/wiki/spaces/UXUI/pages/3243802625/Device+Concept+and+Account+View |
IOS-315 Add tests to PacketTunnelProvider
Add some tests to the new implementation of the Packet Tunnel provider. Ideally, these tests should verify that the packet tunnel lifecycle is sane (starts as expected, enters a blocked state as expected). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed today, the text should say "You have removed this device" instead of "You have revoked this device"
Reviewable status: complete! all files reviewed, all discussions resolved
beb1c2e
to
1b8b729
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
1b8b729
to
0f048c7
Compare
This pull request updates the font weights in the
Revoked Device View
to match the design.This change is