Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-font-weights-in-the-device-revoked-view-ios-377 #5407

Merged

Conversation

mojganii
Copy link
Collaborator

@mojganii mojganii commented Nov 8, 2023

This pull request updates the font weights in the Revoked Device View to match the design.

Before After

This change is Reviewable

Copy link

linear bot commented Nov 8, 2023

IOS-377 Fix spacing and font weights in the "Device revoked" view

Currently, the fonts used are a bit too light in the revoked view, it is clear the view isn't following our design.

This is what it looks like now:

IMG_0982.PNG

And this is what it should look like:

Devices Revoked device Not connected.png

Zeplin: https://app.zeplin.io/project/5f928a32fdc9962af9018d70/screen/619ccb73bb9774163fbbce96

Confluence: https://mullvad.atlassian.net/wiki/spaces/UXUI/pages/3243802625/Device+Concept+and+Account+View

@mojganii mojganii added iOS Issues related to iOS enhancement labels Nov 8, 2023
@mojganii mojganii changed the title make adjust in font styles add-tests-to-packettunnelprovider-ios-315 Nov 8, 2023
Copy link

linear bot commented Nov 8, 2023

IOS-315 Add tests to PacketTunnelProvider

Add some tests to the new implementation of the Packet Tunnel provider.

Ideally, these tests should verify that the packet tunnel lifecycle is sane (starts as expected, enters a blocked state as expected).

@mojganii mojganii changed the title add-tests-to-packettunnelprovider-ios-315 fix-font-weights-in-the-device-revoked-view-ios-377 Nov 8, 2023
Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed today, the text should say "You have removed this device" instead of "You have revoked this device"

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@mojganii mojganii force-pushed the fix-font-weights-in-the-device-revoked-view-ios-377 branch from beb1c2e to 1b8b729 Compare November 9, 2023 14:30
@mojganii mojganii requested a review from buggmagnet November 9, 2023 14:39
Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@buggmagnet buggmagnet force-pushed the fix-font-weights-in-the-device-revoked-view-ios-377 branch from 1b8b729 to 0f048c7 Compare November 10, 2023 11:35
@buggmagnet buggmagnet merged commit 1654b73 into main Nov 10, 2023
3 of 4 checks passed
@buggmagnet buggmagnet deleted the fix-font-weights-in-the-device-revoked-view-ios-377 branch November 10, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement iOS Issues related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants