Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade mockk version to 1.13.8 #5409

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Upgrade mockk version to 1.13.8 #5409

merged 2 commits into from
Nov 10, 2023

Conversation

Pururun
Copy link
Contributor

@Pururun Pururun commented Nov 9, 2023 •
edited by faern
Loading

This change is Reviewable

@Pururun Pururun added the Android Issues related to Android label Nov 9, 2023
@Pururun Pururun requested review from Rawa and sabercodic November 9, 2023 10:12
@Pururun Pururun self-assigned this Nov 9, 2023
@linear Linear
Copy link

linear bot commented Nov 9, 2023

DROID-360 Upgrade mockk version to 1.13.8

We have been blocked to upgrade to a newer version of mockk because of a bug in mockk that seems to have been fixed. We should upgrade to 1.13.8 and check if instrumental tests are passing.

Bug:

mockk/mockk#1035

@Pururun Pururun force-pushed the upgrade-mockk-version-to-1138-droid-360 branch from 59c9f7a to 19471eb Compare November 9, 2023 10:24
albin-mullvad
albin-mullvad approved these changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

sabercodic
sabercodic approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@sabercodic sabercodic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

sabercodic
sabercodic approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@sabercodic sabercodic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Rawa
Rawa approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Pururun Pururun force-pushed the upgrade-mockk-version-to-1138-droid-360 branch 2 times, most recently from 401d92d to 1102cf6 Compare November 10, 2023 11:00
@Pururun Pururun force-pushed the upgrade-mockk-version-to-1138-droid-360 branch from 1102cf6 to bb9b9c2 Compare November 10, 2023 12:47
@Pururun Pururun merged commit c15e285 into main Nov 10, 2023
17 checks passed
@Pururun Pururun deleted the upgrade-mockk-version-to-1138-droid-360 branch November 10, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabercodic sabercodic sabercodic approved these changes

@albin-mullvad albin-mullvad albin-mullvad approved these changes

@Rawa Rawa Rawa approved these changes

Assignees

@Pururun Pururun

Labels
Android Issues related to Android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Pururun @Rawa @albin-mullvad @sabercodic