Exclude build folder from Swiftlint

[rablador]

---

This change is 

[linear]

IOS-382 Exclude build folder from Swiftlint

[rablador]

Also includes some refactoring to remove lint errors.

Reviewable status: 0 of 4 files reviewed, all discussions resolved

[pronebird]

Reviewed 2 of 4 files at r1, 1 of 1 files at r2.
Reviewable status: 3 of 4 files reviewed, 3 unresolved discussions (waiting on @rablador)

---

ios/MullvadVPN/AppDelegate.swift line 118 at r1 (raw file):

        addressCache.loadFromFile()

        setUpProxies(containerURL: containerURL)

It's hard enough to follow what's going on. Perhaps it would be easier if the call to setUpProxies() wouldn't be nested in setUpCaches() and instead would follow the call to setUpCaches()?

---

ios/PacketTunnelCore/Actor/PacketTunnelActor.swift line 334 at r1 (raw file):

    /**
     Create a connection state.

connectedState() doesn't describe particularly well what this method does. It's not even used when the actor is in connected state. The documentation for this method does not describe it either.

Since this method is only used when in initial or error state, it seems that this call is a precursor to [re]connecting state rather than connected state.

It would be more appropriate to call it something along the lines that produces a connection state for connection attempt. Or maybe simply mark it as makeConnectionStateInner() and document what it does.

---

ios/PacketTunnelCore/Actor/PacketTunnelActor.swift line 337 at r1 (raw file):

     - Parameters:
     - nextRelay: next relay to connect to.

Nit: Parameters listed under the "- Parameters:" should be indented with two spaces, I think... Xcode has a bug where it doesn't do that for block comments but it does that for /// comments.

For example:

- Parameters:
  - paramA: <description>
  - paramB: <description> 

[pronebird]

Reviewed 1 of 4 files at r1.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @rablador)

[rablador]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @pronebird)

---

ios/MullvadVPN/AppDelegate.swift line 118 at r1 (raw file):

Previously, pronebird (Andrej Mihajlov) wrote…

It's hard enough to follow what's going on. Perhaps it would be easier if the call to setUpProxies() wouldn't be nested in setUpCaches() and instead would follow the call to setUpCaches()?

I cannot follow the call since setUpProxies() creates the apiProxy that's used inside setUpCaches(). And neither can it precede it. I simply reverted this part and created a smaller refactor of TunnelManager creation intead. I'm not looking for real improvement here, mostly just fix the swiftlint error.

---

ios/PacketTunnelCore/Actor/PacketTunnelActor.swift line 334 at r1 (raw file):

Previously, pronebird (Andrej Mihajlov) wrote…

connectedState() doesn't describe particularly well what this method does. It's not even used when the actor is in connected state. The documentation for this method does not describe it either.

Since this method is only used when in initial or error state, it seems that this call is a precursor to [re]connecting state rather than connected state.

It would be more appropriate to call it something along the lines that produces a connection state for connection attempt. Or maybe simply mark it as makeConnectionStateInner() and document what it does.

Done.

---

ios/PacketTunnelCore/Actor/PacketTunnelActor.swift line 337 at r1 (raw file):

Previously, pronebird (Andrej Mihajlov) wrote…

Nit: Parameters listed under the "- Parameters:" should be indented with two spaces, I think... Xcode has a bug where it doesn't do that for block comments but it does that for /// comments.

For example:

- Parameters:
  - paramA: <description>
  - paramB: <description> 

The rest of the file uses four spaces for comments, so I changed to that.

[pronebird]

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

[buggmagnet]

Reviewed 1 of 4 files at r1, 1 of 2 files at r3.
Reviewable status: 3 of 4 files reviewed, all discussions resolved (waiting on @pronebird)