Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version code check #5414

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Add version code check #5414

merged 1 commit into from
Nov 10, 2023

Conversation

albin-mullvad
Copy link
Collaborator

@albin-mullvad albin-mullvad commented Nov 10, 2023

The check will fail unless the version code is less than 30000000. This means that all version codes up until the year 2030 are valid. The check runs before the preBuild task.


This change is Reviewable

The check will fail unless the version code is less than 30000000.
This means that all version codes up until the year 2030 are valid.
The check runs before the preBuild task.
@albin-mullvad albin-mullvad added the Android Issues related to Android label Nov 10, 2023
@albin-mullvad albin-mullvad requested a review from Rawa November 10, 2023 09:46
@albin-mullvad albin-mullvad self-assigned this Nov 10, 2023
Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@albin-mullvad albin-mullvad merged commit c348289 into main Nov 10, 2023
12 checks passed
@albin-mullvad albin-mullvad deleted the add-version-code-check branch November 10, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants