Add missing text about unblocking Internet on device revoked view #5430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IOS-380 Handle blocked state in the RevokedDeviceViewController
The designs specify that if the device enters the revoked state when connected to a VPN, we should also display the following text "Going to login will unblock the internet on this device" |
rablador
force-pushed
the
handle-blocked-state-in-the-revokeddeviceviewcontroller-ios-380
branch
3 times, most recently
from
1c9f3f7 to
b942577
Compare
buggmagnet
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, all discussions resolved
pronebird
reviewed
Nov 14, 2023
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
buggmagnet
force-pushed
the
handle-blocked-state-in-the-revokeddeviceviewcontroller-ios-380
branch
from
b942577 to
f57a46f
Compare
buggmagnet
deleted the
handle-blocked-state-in-the-revokeddeviceviewcontroller-ios-380
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The designs specify that if the device enters the revoked state when connected to a VPN, we should also display the following text:
"Going to login will unblock the internet on this device"
After adding blocked state this doesn't happen anymore since that isn't supported.
This change is