Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing-importing-a-namespace-partially-ios-385 #5432

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

mojganii
Copy link
Collaborator

@mojganii mojganii commented Nov 14, 2023

This pull request implements the removal of partially importing namespaces.


This change is Reviewable

Copy link

linear bot commented Nov 14, 2023

IOS-385 removing importing a namespace partially

Importing a namespace partially is often recommended in situations where conflicts arise in the names of objects, potentially causing confusion for the compiler. Although this convention is generally helpful, there are instances where partially importing namespaces becomes necessary.

However, it's important to note that Swiftformat includes a rule that automatically converts such namespaces into enums, rendering them non-instantiable. While this is a useful convention, it can introduce some challenges. Therefore, it is commonly agreed to disable this rule in Swiftformat's configuration and avoid partial imports in the codebase to preemptively address potential future issues.

@mojganii mojganii added the iOS Issues related to iOS label Nov 14, 2023
Copy link
Contributor

@pronebird pronebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 33 of 33 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 33 of 33 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@buggmagnet buggmagnet force-pushed the remove_partially_importing_namespaces branch from ae565a7 to 05d3361 Compare November 14, 2023 12:42
@buggmagnet buggmagnet merged commit 5dcf9e3 into main Nov 14, 2023
4 checks passed
@buggmagnet buggmagnet deleted the remove_partially_importing_namespaces branch November 14, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS Issues related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants