Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show success alert when making purchase from "out of time"-view #5439

Merged

Conversation

rablador
Copy link
Contributor

@rablador rablador commented Nov 15, 2023


This change is Reviewable

Copy link

linear bot commented Nov 15, 2023

IOS-313 No "success alert" is shown when buying credit from OutOfTimeView

How to reproduce :

  • Go to profile view
  • Buy credit
  • Notice the alert that says "XXX hours have been added to your account"
  • Go to "Out Of Time" view
  • Buy credit
  • The alert does not show up

We should make this behaviour consistent by making the alert show up here too.

This work should not be started before IOS-175 is merged to main

@rablador rablador requested a review from buggmagnet November 15, 2023 12:54
Copy link
Contributor Author

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMG_3615.PNG

Reviewable status: 0 of 1 files reviewed, all discussions resolved

Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 1 files reviewed, all discussions resolved

@buggmagnet buggmagnet force-pushed the no-success-alert-is-shown-when-buying-credit-from-ios-313 branch from ff5c6f5 to 035040d Compare November 15, 2023 14:27
@buggmagnet buggmagnet merged commit 4557fa0 into main Nov 15, 2023
4 of 5 checks passed
@buggmagnet buggmagnet deleted the no-success-alert-is-shown-when-buying-credit-from-ios-313 branch November 15, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants