Remedy connection check timeouts in test_bridge
#5442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkusPettersson98
force-pushed
the
fix/test_bridge
branch
2 times, most recently
from
c431762 to
da3b703
Compare
dlon
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MarkusPettersson98)
test/test-manager/src/tests/helpers.rs line 494 at r1 (raw file):
.try_into()?; Ok(relay_list.relays().cloned().filter(criteria).collect())
Nit: Could the relays be cloned after filtering?
MarkusPettersson98
force-pushed
the
fix/test_bridge
branch
from
da3b703 to
6f50bee
Compare
There was a problem hiding this comment.
Reviewable status: 4 of 5 files reviewed, all discussions resolved (waiting on @dlon)
test/test-manager/src/tests/helpers.rs line 494 at r1 (raw file):
Previously, dlon (David Lönnhager) wrote…
Nit: Could the relays be cloned after filtering?
Done
MarkusPettersson98
force-pushed
the
fix/test_bridge
branch
from
6f50bee to
0f29d22
Compare
dlon
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
Prefer types from `mullvad-types` over equivavelent types defined in `mullvad-management-interface`.
We have seen `test_bridge` fail due to high latency if slow + far-away servers were selected. Hopefully delegating the task of picking appropriate entry & exit relays will help mitigate this.
MarkusPettersson98
force-pushed
the
fix/test_bridge
branch
from
0f29d22 to
04d0d6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delegate the task of picking entry & exit nodes to the relay selector in
test_bridgebecause of latency concerns.We have seen
test_bridgefail due to high latency if slow + far-away servers wereselected, even with a generous timeout of 10 seconds.
This change is