Reset port when chaning transport protocol #5445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DES-458 Port isn't reset when changing transport protocol
When using OpenVPN and selecting a transport protocol and a port, and then chagning to the other transport protocol (not automatic). After doing this the app ends up in the blocked state due to the port being kept. The port needs to be reset when switching protocol. |
dlon
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
raksooo
force-pushed
the
port-isnt-reset-when-changing-transport-protocol-des-458
branch
from
3ada8a3 to
802e500
Compare
raksooo
deleted the
port-isnt-reset-when-changing-transport-protocol-des-458
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue introduced in #5376. When changing the OpenVPN transport protocol the port isn't reset resulting in the blocked state if connected. This is fixed by resetting the port when changing transport protocol.
This change is