-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing FirewallPolicyError class crash #5454
Fix missing FirewallPolicyError class crash #5454
Conversation
DROID-505 Crash when getting Firewall policy error
Steps to reproduce:
This crash on Google Play might be related: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Pururun)
android/lib/talpid/src/main/kotlin/net/mullvad/talpid/tunnel/FirewallPolicyError.kt
line 8 at r1 (raw file):
@Parcelize enum class FirewallPolicyError : Parcelable { Generic
Is this the only possible enum type that they can send?
Code quote:
Generic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @albin-mullvad)
android/lib/talpid/src/main/kotlin/net/mullvad/talpid/tunnel/FirewallPolicyError.kt
line 8 at r1 (raw file):
Previously, albin-mullvad wrote…
Is this the only possible enum type that they can send?
Yes there is another type that one is windows only.
pub enum FirewallPolicyError {
/// General firewall failure
#[error(display = "Failed to set firewall policy")]
Generic,
/// An application prevented the firewall policy from being set
#[cfg(windows)]
#[error(display = "An application prevented the firewall policy from being set")]
Locked(Option<BlockingApplication>),
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Pururun)
android/lib/talpid/src/main/kotlin/net/mullvad/talpid/tunnel/FirewallPolicyError.kt
line 8 at r1 (raw file):
Previously, Pururun (Jonatan Rhodin) wrote…
Yes there is another type that one is windows only.
pub enum FirewallPolicyError { /// General firewall failure #[error(display = "Failed to set firewall policy")] Generic, /// An application prevented the firewall policy from being set #[cfg(windows)] #[error(display = "An application prevented the firewall policy from being set")] Locked(Option<BlockingApplication>), }
Perfect! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved
ef67779
to
679cb91
Compare
Also as a bonus fixes missing html support for notification banner message which causes
<b>
to appear when showing the Always on VPN error banner.This change is