-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix problem reports not being kept correctly #5457
Fix problem reports not being kept correctly #5457
Conversation
DROID-508 Report a problem input not kept across navigation
The report a problem input isn't kept when navigating away from the report a problem view. Funnily enough, we even emphasize that we will keep the input in the case when we fail to send:
The is a compose migration regression. |
5671345
to
3f7d515
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 7 files at r1, all commit messages.
Reviewable status: 6 of 7 files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Pururun)
a discussion (no related file):
Perhaps we should clear the input on logout? I'm not sure how it worked before 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Pururun)
a discussion (no related file):
Previously, albin-mullvad wrote…
Perhaps we should clear the input on logout? I'm not sure how it worked before 🤔
As mentioned offline, I suggest we keep the behavior we had before the regression was introduced.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @albin-mullvad)
a discussion (no related file):
Previously, albin-mullvad wrote…
As mentioned offline, I suggest we keep the behavior we had before the regression was introduced.
Test on current production and email and message was not deleted if the user logged out, so we have the same behaviour as before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @albin-mullvad)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved
3f7d515
to
a3502f5
Compare
Also restore secure view behaviour for Send report problem success screen.
This change is