Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem reports not being kept correctly #5457

Merged

Conversation

Pururun
Copy link
Contributor

@Pururun Pururun commented Nov 17, 2023

Also restore secure view behaviour for Send report problem success screen.


This change is Reviewable

@Pururun Pururun requested review from Rawa and sabercodic November 17, 2023 12:31
Copy link

linear bot commented Nov 17, 2023

DROID-508 Report a problem input not kept across navigation

The report a problem input isn't kept when navigating away from the report a problem view. Funnily enough, we even emphasize that we will keep the input in the case when we fail to send:

If you exit the form and try again later, the information you already entered will still be there.

The is a compose migration regression.

@Pururun Pururun force-pushed the report-a-problem-input-not-kept-across-navigation-droid-508 branch from 5671345 to 3f7d515 Compare November 17, 2023 12:32
@Pururun Pururun self-assigned this Nov 17, 2023
@Pururun Pururun added the Android Issues related to Android label Nov 17, 2023
Copy link
Contributor

@sabercodic sabercodic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 7 files at r1, all commit messages.
Reviewable status: 6 of 7 files reviewed, all discussions resolved

Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Pururun)

a discussion (no related file):
Perhaps we should clear the input on logout? I'm not sure how it worked before 🤔


Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Pururun)

a discussion (no related file):

Previously, albin-mullvad wrote…

Perhaps we should clear the input on logout? I'm not sure how it worked before 🤔

As mentioned offline, I suggest we keep the behavior we had before the regression was introduced.


Copy link
Contributor Author

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @albin-mullvad)

a discussion (no related file):

Previously, albin-mullvad wrote…

As mentioned offline, I suggest we keep the behavior we had before the regression was introduced.

Test on current production and email and message was not deleted if the user logged out, so we have the same behaviour as before.


Copy link
Contributor

@sabercodic sabercodic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @albin-mullvad)

Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@albin-mullvad albin-mullvad force-pushed the report-a-problem-input-not-kept-across-navigation-droid-508 branch from 3f7d515 to a3502f5 Compare November 17, 2023 15:19
@albin-mullvad albin-mullvad merged commit 1cd0cbc into main Nov 17, 2023
9 checks passed
@albin-mullvad albin-mullvad deleted the report-a-problem-input-not-kept-across-navigation-droid-508 branch November 17, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants