Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with the welcome screen showing up after buying time #5465

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Fix issue with the welcome screen showing up after buying time #5465

merged 1 commit into from
Nov 22, 2023

Conversation

Pururun
Copy link
Contributor

@Pururun Pururun commented Nov 17, 2023 •
edited by faern
Loading

This change is Reviewable

@Pururun Pururun added the Android Issues related to Android label Nov 17, 2023
@Pururun Pururun self-assigned this Nov 17, 2023
@linear Linear
Copy link

linear bot commented Nov 17, 2023

DROID-499 Welcome screen is shown after app restart

Steps to reproduce:

  1. Create an account
  2. In the welcome screen, add time either through voucher or Google
  3. After time is added connect to a relay
  4. Set the app in a blocking state by for example setting custom dns to 0.0.0.0
  5. Close the app by opening recent applications and swiping it away
  6. Start the app and you should now be taken to the Welcome Screen again

Expected behaviour:

User should be taken to the connect screen.

@Pururun Pururun force-pushed the welcome-screen-is-shown-after-app-restart-droid-499 branch from 030abf2 to 22c8ac8 Compare November 20, 2023 08:53
albin-mullvad
albin-mullvad approved these changes Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Rawa
Rawa approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Pururun Pururun force-pushed the welcome-screen-is-shown-after-app-restart-droid-499 branch from 22c8ac8 to 41779a0 Compare November 21, 2023 11:43
@Pururun Pururun force-pushed the welcome-screen-is-shown-after-app-restart-droid-499 branch from 41779a0 to 657f1c3 Compare November 21, 2023 15:42
@Pururun Pururun merged commit c13ec3c into main Nov 22, 2023
13 checks passed
@Pururun Pururun deleted the welcome-screen-is-shown-after-app-restart-droid-499 branch November 22, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albin-mullvad albin-mullvad albin-mullvad approved these changes

@Rawa Rawa Rawa approved these changes

Assignees

@Pururun Pururun

Labels
Android Issues related to Android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pururun @Rawa @albin-mullvad