Stop using old completion based MullvadREST interface #5470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IOS-367 Stop using old completion based MullvadREST interface
The old interface has been deprecated - all call sites should be transitioned over to use the new interface that works with both completion handlers and async/await. Migrating all call sites to async/await is not a part of this task, that should only be done in the trivial cases. |
buggmagnet
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
buggmagnet
force-pushed
the
stop-using-old-completion-based-mullvadrest-interface-ios-367
branch
from
9775454 to
d1e60b8
Compare
buggmagnet
deleted the
stop-using-old-completion-based-mullvadrest-interface-ios-367
branch
pronebird
reviewed
Nov 27, 2023
There was a problem hiding this comment.
Reviewed 11 of 11 files at r1.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old interface has been deprecated - all call sites should be transitioned over to use the new interface that works with both completion handlers and async/await. Migrating all call sites to async/await is not a part of this task, that should only be done in the trivial cases.
This change is