Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset purchase state when automatically leaving a screen #5471

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Reset purchase state when automatically leaving a screen #5471

merged 1 commit into from
Nov 22, 2023

Conversation

Pururun
Copy link
Contributor

@Pururun Pururun commented Nov 20, 2023 •
edited by faern
Loading

This change is Reviewable

@Pururun Pururun added the Android Issues related to Android label Nov 20, 2023
@Pururun Pururun self-assigned this Nov 20, 2023
@linear Linear
Copy link

linear bot commented Nov 20, 2023

DROID-514 Purchase state is not reset correctly sometimes

If the user is in the WelcomeScreen or OutofTimeScreen and they are automatically transfered to the ConnectScreen purchase state is not reset to nullcorrectly.

albin-mullvad
albin-mullvad approved these changes Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Pururun Pururun force-pushed the purchase-state-is-not-reset-correctly-sometimes-droid-514 branch 2 times, most recently from 9592025 to 8b89cf3 Compare November 21, 2023 15:47
@Pururun Pururun force-pushed the purchase-state-is-not-reset-correctly-sometimes-droid-514 branch from 8b89cf3 to a2b9881 Compare November 22, 2023 07:34
@Pururun Pururun merged commit 312a004 into main Nov 22, 2023
13 checks passed
@Pururun Pururun deleted the purchase-state-is-not-reset-correctly-sometimes-droid-514 branch November 22, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albin-mullvad albin-mullvad albin-mullvad approved these changes

@Rawa Rawa Awaiting requested review from Rawa

Assignees

@Pururun Pururun

Labels
Android Issues related to Android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pururun @albin-mullvad