Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AGP & SDK version to 34 #5473

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Update AGP & SDK version to 34 #5473

merged 3 commits into from
Nov 21, 2023

Conversation

Rawa
Copy link
Contributor

@Rawa Rawa commented Nov 21, 2023 •
edited by faern
Loading

This change is Reviewable

@Rawa Rawa requested a review from albin-mullvad November 21, 2023 10:06
@linear Linear
Copy link

linear bot commented Nov 21, 2023

DROID-472 Update to compileSdk & targetSdk 34

rawa said:

Something we need to take care of in the near future:
https://developer.android.com/about/versions/14/changes/fgs-types-required

Foreground service types are required  |  Android Developers

@Rawa Rawa requested a review from Pururun November 21, 2023 10:06
@Pururun Pururun added the Android Issues related to Android label Nov 21, 2023
@Rawa Rawa mentioned this pull request Nov 21, 2023
Merged
@Rawa Rawa self-assigned this Nov 21, 2023
@Pururun Pururun force-pushed the update-to-compilesdk-targetsdk-34-droid-472 branch from a2231f1 to 888a9c7 Compare November 21, 2023 10:54
@Rawa Rawa force-pushed the update-to-compilesdk-targetsdk-34-droid-472 branch from 888a9c7 to 2c8d4ad Compare November 21, 2023 11:43
Pururun
Pururun approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

albin-mullvad
albin-mullvad approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Pururun Pururun force-pushed the update-to-compilesdk-targetsdk-34-droid-472 branch from b8999ee to 850b405 Compare November 21, 2023 14:39
Pururun
Pururun approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Pururun Pururun merged commit e98cece into main Nov 21, 2023
19 checks passed
@Pururun Pururun deleted the update-to-compilesdk-targetsdk-34-droid-472 branch November 21, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albin-mullvad albin-mullvad albin-mullvad approved these changes

@Pururun Pururun Pururun approved these changes

Assignees

@Rawa Rawa

Labels
Android Issues related to Android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rawa @Pururun @albin-mullvad