Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add value class assertion test #5474

Conversation

Rawa
Copy link
Contributor

@Rawa Rawa commented Nov 21, 2023


This change is Reviewable

Copy link

linear bot commented Nov 21, 2023

DROID-489 Ensure all value classes only contain one property named value

We should add a #konsist test that ensures that we only have one property named value as per best practice.

E.g:

value class Port(value: Int)

which well be accessed by:

port.value

@Rawa Rawa force-pushed the ensure-all-value-classes-only-contain-one-property-named-droid-489 branch from 53c5fc4 to d4f3319 Compare November 21, 2023 10:17
@Pururun Pururun added the Android Issues related to Android label Nov 21, 2023
@Rawa Rawa self-assigned this Nov 21, 2023
@Rawa Rawa force-pushed the ensure-all-value-classes-only-contain-one-property-named-droid-489 branch from d4f3319 to 79c53ac Compare November 21, 2023 11:44
Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Pururun Pururun force-pushed the ensure-all-value-classes-only-contain-one-property-named-droid-489 branch from 79c53ac to 2ef9a24 Compare November 22, 2023 08:02
@Pururun Pururun merged commit 78c485d into main Nov 22, 2023
14 checks passed
@Pururun Pururun deleted the ensure-all-value-classes-only-contain-one-property-named-droid-489 branch November 22, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants