Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix account history events being lost because of buffer overflow #5476

Merged

Conversation

Pururun
Copy link
Contributor

@Pururun Pururun commented Nov 21, 2023


This change is Reviewable

Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Pururun)


android/lib/ipc/src/main/kotlin/net/mullvad/mullvadvpn/lib/ipc/DispatchingHandler.kt line 18 at r1 (raw file):

    private val lock = ReentrantReadWriteLock()

    private val _parsedMessages = MutableSharedFlow<T>(extraBufferCapacity = 10)

Perhaps we can add a documented constant? Otherwise looks good.

Code quote:

10

@Pururun Pururun self-assigned this Nov 21, 2023
@Pururun Pururun added the Android Issues related to Android label Nov 21, 2023
Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @albin-mullvad)


android/lib/ipc/src/main/kotlin/net/mullvad/mullvadvpn/lib/ipc/DispatchingHandler.kt line 18 at r1 (raw file):

Previously, albin-mullvad wrote…

Perhaps we can add a documented constant? Otherwise looks good.

Agree

Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @albin-mullvad)

@Pururun Pururun force-pushed the inconsistent-behavior-of-the-account-history-droid-519 branch from e238ae1 to 142f080 Compare November 22, 2023 07:46
Copy link
Contributor Author

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @albin-mullvad)


android/lib/ipc/src/main/kotlin/net/mullvad/mullvadvpn/lib/ipc/DispatchingHandler.kt line 18 at r1 (raw file):

Previously, Rawa (David Göransson) wrote…

Agree

Added

Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Pururun Pururun force-pushed the inconsistent-behavior-of-the-account-history-droid-519 branch from 142f080 to c1c2cba Compare November 22, 2023 13:55
@Pururun Pururun merged commit 507e5c9 into main Nov 22, 2023
12 checks passed
@Pururun Pururun deleted the inconsistent-behavior-of-the-account-history-droid-519 branch November 22, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants