-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace text share with file share #5485
Conversation
7d4da6a
to
5cd1f20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 4 files at r1, 2 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Rawa)
android/app/src/main/res/values/strings.xml
line 4 at r2 (raw file):
<resources> <string name="copied_logs_to_clipboard">Copied logs to clipboard</string> </resources>
No proper file ending
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Rawa)
5cd1f20
to
b0eef37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @albin-mullvad)
android/app/src/main/res/values/strings.xml
line 4 at r2 (raw file):
Previously, albin-mullvad wrote…
No proper file ending
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
5f1eeb3
to
9fad8cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
9fad8cf
to
cd6deaa
Compare
cd6deaa
to
90689b3
Compare
Attempt of sharing text through share intent don't work due to the text being too long, this PR replaces it by sharing it as a file instead. This PR also offers the option to directly copy the logs into clipboard.
It is possible to crash system UI with this PR since the new Copy dialog from system also offers a "share" functionality which will share the logs in a similar fashion as we did before, thus causing
intentChooser
to fail due to the text being too long.. To reproduce this add,repeat(5)
inViewLogsUiState
to thetext()
functionThis change is