Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace text share with file share #5485

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

Rawa
Copy link
Contributor

@Rawa Rawa commented Nov 22, 2023

Attempt of sharing text through share intent don't work due to the text being too long, this PR replaces it by sharing it as a file instead. This PR also offers the option to directly copy the logs into clipboard.

It is possible to crash system UI with this PR since the new Copy dialog from system also offers a "share" functionality which will share the logs in a similar fashion as we did before, thus causing intentChooser to fail due to the text being too long.. To reproduce this add, repeat(5) in ViewLogsUiState to the text() function


This change is Reviewable

Copy link

linear bot commented Nov 22, 2023

@Rawa Rawa force-pushed the crash-when-clicking-share-button-droid-518 branch 2 times, most recently from 7d4da6a to 5cd1f20 Compare November 27, 2023 09:59
@albin-mullvad albin-mullvad added Android Issues related to Android bug labels Nov 27, 2023
Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 4 files at r1, 2 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Rawa)


android/app/src/main/res/values/strings.xml line 4 at r2 (raw file):

<resources>
    <string name="copied_logs_to_clipboard">Copied logs to clipboard</string>
</resources>

No proper file ending

Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Rawa)

@Rawa Rawa force-pushed the crash-when-clicking-share-button-droid-518 branch from 5cd1f20 to b0eef37 Compare November 27, 2023 14:31
Copy link
Contributor Author

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @albin-mullvad)


android/app/src/main/res/values/strings.xml line 4 at r2 (raw file):

Previously, albin-mullvad wrote…

No proper file ending

Done.

Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Rawa Rawa force-pushed the crash-when-clicking-share-button-droid-518 branch 2 times, most recently from 5f1eeb3 to 9fad8cf Compare November 27, 2023 14:37
Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@albin-mullvad albin-mullvad force-pushed the crash-when-clicking-share-button-droid-518 branch from 9fad8cf to cd6deaa Compare November 27, 2023 15:15
@Pururun Pururun force-pushed the crash-when-clicking-share-button-droid-518 branch from cd6deaa to 90689b3 Compare November 27, 2023 15:16
@Pururun Pururun merged commit 851b134 into main Nov 27, 2023
17 checks passed
@Pururun Pururun deleted the crash-when-clicking-share-button-droid-518 branch November 27, 2023 15:21
@Rawa Rawa self-assigned this Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants