Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add payment verification to Connect Screen #5487

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

Pururun
Copy link
Contributor

@Pururun Pururun commented Nov 22, 2023


This change is Reviewable

@Pururun Pururun requested review from Rawa and sabercodic November 22, 2023 16:40
Copy link

linear bot commented Nov 22, 2023

DROID-516 Try to verify in ConnectScreen

We should add more places to attempt verification again if the verification failed.

@Pururun Pururun self-assigned this Nov 22, 2023
@Pururun Pururun added the Android Issues related to Android label Nov 22, 2023
@Pururun Pururun force-pushed the try-to-verify-in-connectscreen-droid-516 branch from 949492d to 530e055 Compare November 22, 2023 16:50
Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Pururun Pururun force-pushed the try-to-verify-in-connectscreen-droid-516 branch from 530e055 to 7d11988 Compare November 27, 2023 14:25
@albin-mullvad albin-mullvad force-pushed the try-to-verify-in-connectscreen-droid-516 branch from 7d11988 to 022952d Compare November 27, 2023 14:44
@albin-mullvad albin-mullvad merged commit a062df8 into main Nov 27, 2023
10 checks passed
@albin-mullvad albin-mullvad deleted the try-to-verify-in-connectscreen-droid-516 branch November 27, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants