Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default route MTU when using multihop on Linux #5501

Merged
merged 3 commits into from
Dec 4, 2023

Conversation

dlon
Copy link
Member

@dlon dlon commented Nov 25, 2023

This prevents fragmentation when multihop is enabled.

Fix DES-483.


This change is Reviewable

@dlon dlon requested a review from pinkisemils November 25, 2023 16:24
@dlon dlon force-pushed the linux-lower-entry-multihop-mtu branch from 0571a47 to 6d2ec75 Compare November 25, 2023 16:30
@dlon dlon marked this pull request as ready for review November 25, 2023 16:36
@dlon dlon force-pushed the linux-lower-entry-multihop-mtu branch 3 times, most recently from 040f085 to ac2ec9b Compare November 27, 2023 08:49
Copy link

linear bot commented Nov 27, 2023

Copy link
Collaborator

@pinkisemils pinkisemils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 6 files at r1.
Reviewable status: 5 of 6 files reviewed, 1 unresolved discussion (waiting on @dlon)


talpid-wireguard/src/lib.rs line 484 at r1 (raw file):

        if config.peers.len() > 1 {
            if config.peers.len() != 2 {

I presume we would support an arbitrary amount of peers now?

@dlon dlon force-pushed the linux-lower-entry-multihop-mtu branch 4 times, most recently from fcbc99c to 9cfc79a Compare November 30, 2023 12:53
Copy link
Member Author

@dlon dlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 4 of 9 files reviewed, 1 unresolved discussion (waiting on @pinkisemils)


talpid-wireguard/src/lib.rs line 484 at r1 (raw file):

Previously, pinkisemils (Emīls Piņķis) wrote…

I presume we would support an arbitrary amount of peers now?

I've made Config less generic to remove all of the hidden assumptions.

@dlon dlon force-pushed the linux-lower-entry-multihop-mtu branch 2 times, most recently from 3b16b53 to 45e024c Compare November 30, 2023 13:04
Copy link
Collaborator

@pinkisemils pinkisemils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 5 files at r3, all commit messages.
Reviewable status: 5 of 9 files reviewed, 1 unresolved discussion (waiting on @dlon)


talpid-wireguard/src/lib.rs line 920 at r4 (raw file):

            let ip_overhead = match route.prefix.is_ipv4() {
                true => IPV4_HEADER_SIZE,

Do we adjust the MTU size when connecting over IPv6 instead of IPv4 too?

Copy link
Collaborator

@pinkisemils pinkisemils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 5 files at r3, 1 of 1 files at r4.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dlon)

@dlon dlon force-pushed the linux-lower-entry-multihop-mtu branch from 45e024c to b07301e Compare December 4, 2023 11:51
@dlon dlon force-pushed the linux-lower-entry-multihop-mtu branch from b07301e to 88a04da Compare December 4, 2023 11:54
@dlon dlon merged commit d4ed3bf into main Dec 4, 2023
@dlon dlon deleted the linux-lower-entry-multihop-mtu branch December 4, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants