-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set default route MTU when using multihop on Linux #5501
Conversation
0571a47
to
6d2ec75
Compare
040f085
to
ac2ec9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 6 files at r1.
Reviewable status: 5 of 6 files reviewed, 1 unresolved discussion (waiting on @dlon)
talpid-wireguard/src/lib.rs
line 484 at r1 (raw file):
if config.peers.len() > 1 { if config.peers.len() != 2 {
I presume we would support an arbitrary amount of peers now?
fcbc99c
to
9cfc79a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 4 of 9 files reviewed, 1 unresolved discussion (waiting on @pinkisemils)
talpid-wireguard/src/lib.rs
line 484 at r1 (raw file):
Previously, pinkisemils (Emīls Piņķis) wrote…
I presume we would support an arbitrary amount of peers now?
I've made Config
less generic to remove all of the hidden assumptions.
3b16b53
to
45e024c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 5 files at r3, all commit messages.
Reviewable status: 5 of 9 files reviewed, 1 unresolved discussion (waiting on @dlon)
talpid-wireguard/src/lib.rs
line 920 at r4 (raw file):
let ip_overhead = match route.prefix.is_ipv4() { true => IPV4_HEADER_SIZE,
Do we adjust the MTU size when connecting over IPv6 instead of IPv4 too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 5 files at r3, 1 of 1 files at r4.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dlon)
45e024c
to
b07301e
Compare
b07301e
to
88a04da
Compare
This prevents fragmentation when multihop is enabled.
Fix DES-483.
This change is