Parse JSON blobs more leniently

[dlon]

Specifically:

• Add missing outer braces, if missing
• Ignore "comment" lines, i.e. lines beginning with '#'

As an example, this is now valid:

# Add my override
"relay_overrides": [{ "hostname": "test", "ipv4_addr_in": "1.3.3.7" }]

The above is equivalent to

{
    "relay_overrides": [{ "hostname": "test", "ipv4_addr_in": "1.3.3.7" }]
}

Fix DES-478.

---

This change is 

[linear]

DES-478 Parse settings patches less strictly

1. Make the outer braces optional. This should be a valid patch:

"relay_overrides": [
  { "hostname": "se-got-wg-001", "ipv4_addr_in": "1.2.3.4" }
]

2. Trim trailing commas in lists/objects.
3. When an array is expected but some other value is found, treat it as an array containing that value.
4. Ignore "comments" (i.e. lines beginning with #).

[MarkusPettersson98]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dlon)

---

mullvad-daemon/src/settings/patch.rs line 206 at r2 (raw file):

        .filter(|line| !line.trim_start().starts_with('#'))
        .collect::<Vec<_>>()
        .join("\n");

This should be refactored to it's own function, and combining multiple transformations be done via composition / chaining function calls instead 😊

Code quote:

    // Remove commented lines
    let mut patch = json_patch
        .lines()
        .filter(|line| !line.trim_start().starts_with('#'))
        .collect::<Vec<_>>()
        .join("\n");

[dlon]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @MarkusPettersson98)

---

mullvad-daemon/src/settings/patch.rs line 206 at r2 (raw file):

Previously, MarkusPettersson98 (Markus Pettersson) wrote…

This should be refactored to it's own function, and combining multiple transformations be done via composition / chaining function calls instead 😊

Done.

[MarkusPettersson98]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved