-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select targets to run tests on in GitHub Actions #5507
Conversation
e1a3965
to
c228c8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @dlon)
.github/workflows/desktop-e2e.yml
line 25 at r1 (raw file):
else oses=$(printf '%s\n' "$oses" | jq . -R | jq . -s) selected=$(jq -cn --argjson oses "$oses" --argjson all "$all" '$all - ($all - $oses)')
jq -cn '$all - ($all - $oses)'
will evaluate to simply $oses
😄
It should be possible to simplify the expression which is assigned to selected
Code quote:
selected=$(jq -cn --argjson oses "$oses" --argjson all "$all" '$all - ($all - $oses)')
.github/workflows/desktop-e2e.yml
line 38 at r1 (raw file):
else oses=$(printf '%s\n' "$oses" | jq . -R | jq . -s) selected=$(jq -cn --argjson oses "$oses" --argjson all "$all" '$all - ($all - $oses)')
dito
Code quote:
selected=$(jq -cn --argjson oses "$oses" --argjson all "$all" '$all - ($all - $oses)')
.github/workflows/desktop-e2e.yml
line 51 at r1 (raw file):
else oses=$(printf '%s\n' "$oses" | jq . -R | jq . -s) selected=$(jq -cn --argjson oses "$oses" --argjson all "$all" '$all - ($all - $oses)')
dito
Code quote:
selected=$(jq -cn --argjson oses "$oses" --argjson all "$all" '$all - ($all - $oses)')
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @MarkusPettersson98)
.github/workflows/desktop-e2e.yml
line 25 at r1 (raw file):
Previously, MarkusPettersson98 (Markus Pettersson) wrote…
jq -cn '$all - ($all - $oses)'
will evaluate to simply$oses
😄
It should be possible to simplify the expression which is assigned toselected
It's not the same as $oses
. It only returns the intersection of the two
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dlon)
.github/workflows/desktop-e2e.yml
line 25 at r1 (raw file):
Previously, dlon (David Lönnhager) wrote…
It's not the same as
$oses
. It only returns the intersection of the two
Yes, you are completely correct!
00c893d
to
c0054bc
Compare
c0054bc
to
63e4682
Compare
This lets us run tests on only a subset of supported OSes.
Fix DES-484.
This change is