Refactor packet tunnel to use only a single network path observer #5514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IOS-401 Refactor packet tunnel to use only a single network path observer
The packet tunnel provider supplies both the actor and tunnel monitor with its own network path observer, which isn't ideal and makes the code harder to follow. |
buggmagnet
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
buggmagnet
force-pushed
the
refactor-packet-tunnel-to-use-only-a-single-network-path-ios-401
branch
from
d1afc2f to
18e21fa
Compare
pronebird
reviewed
Nov 29, 2023
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1.
Reviewable status:
buggmagnet
deleted the
refactor-packet-tunnel-to-use-only-a-single-network-path-ios-401
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The packet tunnel provider supplies both the actor and tunnel monitor with its own network path observer, which isn't ideal and makes the code harder to follow.
This change is