Do not show account revoked banner when on account revoked screen

[rablador]

A banner with a blocked state reason (unable to authenticate account) is shown when on the account revoked screen. This is superfluous information.

---

This change is 

[linear]

IOS-396 When the revoked view is shown and the app fails to reconnect again, the in-app banner is shown

signal-2023-11-21-151952.png

To trigger this bug, revoke your device and toggle the VPN connection from the settings app.

[mojganii]

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @rablador)

---

ios/MullvadVPN/Notifications/Notification Providers/TunnelStatusNotificationProvider.swift line 69 at r1 (raw file):

    }

    private func updateLastTunnelError(_ tunnelState: TunnelState) -> Bool {

the function is doing two responsibilities that makes readability more complex.I suggest export these sort of conditions from your class to make is shorter and more descriptive

Code snippet:

fileprivate extension TunnelState {
    var isWaitingForConnectivity : Bool {
        self == .waitingForConnectivity(.noConnection)
    }
    
    var noNetwork : Bool {
        self == .waitingForConnectivity(.noConnection)
    }
    
    var accountIsInvalid : Bool {
        if case let .error(blockedStateReason) = self,
           blockedStateReason == .accountExpired || blockedStateReason == .deviceRevoked {
            return true
        }
        return false
    }
    
}

---

ios/MullvadVPN/Notifications/Notification Providers/TunnelStatusNotificationProvider.swift line 229 at r1 (raw file):

    }

    private func localizedReasonForBlockedStateError(_ error: BlockedStateReason) -> String {

I think this part can be common along different type of objects

Code snippet:

extension BlockedStateReason : CustomStringConvertible {
    public var description: String {
        let errorString: String
        
        switch self {
        case .outdatedSchema:
            errorString = "Unable to start tunnel connection after update. Please disconnect and reconnect."
        case .noRelaysSatisfyingConstraints:
            errorString = "No servers match your settings, try changing server or other settings."
        case .invalidAccount:
            errorString = "You are logged in with an invalid account number. Please log out and try another one."
        case .deviceRevoked, .deviceLoggedOut:
            errorString = "Unable to authenticate account. Please log out and log back in."
        default:
            errorString = "Unable to start tunnel connection. Please send a problem report."
        }
        
        return NSLocalizedString(
            "BLOCKED_STATE_ERROR_TITLE",
            tableName: "Main",
            value: errorString,
            comment: ""
        )
    }
}

[rablador]

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @mojganii)

---

ios/MullvadVPN/Notifications/Notification Providers/TunnelStatusNotificationProvider.swift line 69 at r1 (raw file):

Previously, mojganii wrote…

the function is doing two responsibilities that makes readability more complex.I suggest export these sort of conditions from your class to make is shorter and more descriptive

As was discussed elsewhere we should probably not add concepts such as account validation to TunnelState, but I extracted some of the code to a new function to lower complexity.

---

ios/MullvadVPN/Notifications/Notification Providers/TunnelStatusNotificationProvider.swift line 229 at r1 (raw file):

Previously, mojganii wrote…

I think this part can be common along different type of objects

I don't think we need to make these strings generally accessible at this point, since they're only used here anyway. Once we need them elsewhere I agree with your suggestion.

[buggmagnet]

Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @mojganii and @rablador)

---

ios/MullvadVPN/Notifications/Notification Providers/TunnelStatusNotificationProvider.swift line 120 at r2 (raw file):

    }

    private func tunnelError(from tunnelState: TunnelState) -> BlockedStateReason? {

Without context, it's impossible to figure out why we do this here.
Can you add a comment that explains why we filter only for accountExpired and deviceRevoked errors ?

[rablador]

Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @buggmagnet and @mojganii)

---

ios/MullvadVPN/Notifications/Notification Providers/TunnelStatusNotificationProvider.swift line 120 at r2 (raw file):

Previously, buggmagnet wrote…

Without context, it's impossible to figure out why we do this here.
Can you add a comment that explains why we filter only for accountExpired and deviceRevoked errors ?

Done.

[buggmagnet]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @mojganii)