Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary else block within when statements #5536

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Remove unnecessary else block within when statements #5536

merged 1 commit into from
Dec 4, 2023

Conversation

sabercodic
Copy link
Contributor

@sabercodic sabercodic commented Dec 1, 2023 •
edited by faern
Loading

This change is Reviewable

@sabercodic sabercodic added the Android Issues related to Android label Dec 1, 2023
@linear Linear
Copy link

linear bot commented Dec 1, 2023

DROID-541 Code clean up for conditional statements

Pururun
Pururun approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Rawa
Rawa approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@sabercodic sabercodic force-pushed the code-clean-up-for-conditional-statements-droid-541 branch from 077c718 to fd3ecd6 Compare December 4, 2023 12:58
@Pururun Pururun force-pushed the code-clean-up-for-conditional-statements-droid-541 branch from fd3ecd6 to 5ff2638 Compare December 4, 2023 15:19
@Pururun Pururun merged commit 25788c6 into main Dec 4, 2023
14 checks passed
@Pururun Pururun deleted the code-clean-up-for-conditional-statements-droid-541 branch December 4, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pururun Pururun Pururun approved these changes

@Rawa Rawa Rawa approved these changes

@albin-mullvad albin-mullvad Awaiting requested review from albin-mullvad

Assignees
No one assigned
Labels
Android Issues related to Android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sabercodic @Rawa @Pururun