Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check network availability #5537

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Check network availability #5537

merged 3 commits into from
Dec 7, 2023

Conversation

MaryamShaghaghi
Copy link
Contributor

@MaryamShaghaghi MaryamShaghaghi commented Dec 1, 2023 •
edited by faern
Loading

This change is Reviewable

@Pururun Pururun added the Android Issues related to Android label Dec 1, 2023
Pururun
Pururun approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Pururun
Pururun requested changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix the test. Also could be nice to write a small test to test your functionality. :)

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

MaryamShaghaghi
MaryamShaghaghi commented Dec 1, 2023
View reviewed changes
Copy link
Contributor Author

@MaryamShaghaghi MaryamShaghaghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okey, will do that.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Pururun
Pururun approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@MaryamShaghaghi MaryamShaghaghi force-pushed the wip_hackday_project branch 2 times, most recently from fd0cb8c to 07e15d6 Compare December 7, 2023 09:09
Pururun
Pururun approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 5 files at r4, 1 of 1 files at r5, 1 of 1 files at r6, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Pururun Pururun merged commit aed7c8d into mullvad:main Dec 7, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pururun Pururun Pururun approved these changes

Assignees
No one assigned
Labels
Android Issues related to Android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaryamShaghaghi @Pururun