Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update account history on login/create account #5546

Conversation

Rawa
Copy link
Contributor

@Rawa Rawa commented Dec 4, 2023

This PR makes sure we update the cache of account history after login so we don't accidentally store previously logged in account for too long in memory.


This change is Reviewable

Copy link

linear bot commented Dec 4, 2023

@Rawa Rawa force-pushed the old-account-number-shows-up-in-account-history-for-a-brief-droid-546 branch from f8dc077 to 7a80a35 Compare December 4, 2023 15:09
@Rawa Rawa self-assigned this Dec 5, 2023
@Rawa Rawa added the Android Issues related to Android label Dec 5, 2023
Copy link
Contributor

@sabercodic sabercodic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@sabercodic sabercodic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Pururun Pururun force-pushed the old-account-number-shows-up-in-account-history-for-a-brief-droid-546 branch from 7a80a35 to 0beed23 Compare December 7, 2023 10:21
@Pururun Pururun merged commit 4003ba7 into main Dec 7, 2023
15 checks passed
@Pururun Pururun deleted the old-account-number-shows-up-in-account-history-for-a-brief-droid-546 branch December 7, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants