Reflect obfuscation protocol in UI ios 398

[buggmagnet]

Final part of the UDP-over-TCP obfuscation feature.

This PR :

• Refactors TunnelControlViewModel
• Unifies how TunnelControlView gets its data source (more could be done, but the PR was already big enough)
• Resurfaces the port and protocol layer used by the Packet Tunnel to connect to an endpoint
• Introduces an ObfuscateConnection method that will take a MullvadEndpoint and seamlessly create an obfsucator to use

---

This change is 

[linear]

IOS-398 Reflect TCP protocol usage in the UI ingress IP when using UDP-over-TCP Obfuscation

[rablador]

Reviewed 15 of 15 files at r1, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @buggmagnet)

---

ios/MullvadVPN/View controllers/Tunnel/TunnelControlView.swift line 156 at r1 (raw file):

        countryLabel.attributedText = attributedStringForLocation(string: model.country)
        connectionPanel.connectedRelayName = model.connectedRelayName
        connectionPanel.dataSource = model.connectionPanel

Duplicate line.

---

ios/MullvadVPN/View controllers/Tunnel/TunnelControlViewModel.swift line 38 at r1 (raw file):

    }

    init(from other: TunnelControlViewModel) {

This seems to never be used.

---

ios/PacketTunnelCore/Actor/PacketTunnelActor.swift line 344 at r1 (raw file):

        reason: ReconnectReason
    ) throws -> ConnectionState? {
        guard let connectionState = try makeConnectionState(nextRelay: nextRelay, settings: settings, reason: reason)

We now have three function in a chain handling the creation of a connection state, which seems unnecessarily deep. Also, we always overwrite the last three params in ConnectionState before returning, which makes things feel even more disjointed. Could we perhaps refactor these three function into one or two somehow?

---

ios/PacketTunnelCore/Actor/ProtocolObfuscator.swift line 35 at r1 (raw file):

    public var transportLayer: TransportLayer? {
        guard let tunnelObfuscator else { return nil }
        return tunnelObfuscator.transportLayer

Nit: Simplify to return tunnelObfuscator?.transportLayer?

[buggmagnet]

Reviewable status: 6 of 15 files reviewed, 4 unresolved discussions (waiting on @rablador)

---

ios/MullvadVPN/View controllers/Tunnel/TunnelControlView.swift line 156 at r1 (raw file):

Previously, rablador (Jon Petersson) wrote…

Duplicate line.

Done.

---

ios/MullvadVPN/View controllers/Tunnel/TunnelControlViewModel.swift line 38 at r1 (raw file):

Previously, rablador (Jon Petersson) wrote…

This seems to never be used.

You're right, it looks like I forgot to remove that from an old revision. Good catch !

---

ios/PacketTunnelCore/Actor/PacketTunnelActor.swift line 344 at r1 (raw file):

Previously, rablador (Jon Petersson) wrote…

We now have three function in a chain handling the creation of a connection state, which seems unnecessarily deep. Also, we always overwrite the last three params in ConnectionState before returning, which makes things feel even more disjointed. Could we perhaps refactor these three function into one or two somehow?

Done.

---

ios/PacketTunnelCore/Actor/ProtocolObfuscator.swift line 35 at r1 (raw file):

Previously, rablador (Jon Petersson) wrote…

Nit: Simplify to return tunnelObfuscator?.transportLayer?

Yup !

[rablador]

Reviewed 8 of 9 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved